Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: desktop-options.html

Issue 29655630: Issue 5873 - Show original subscription title in languages table (Closed)
Patch Set: Created Jan. 3, 2018, 8:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | desktop-options.js » ('j') | desktop-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 <div id="content-general" role="tabpanel" aria-labelledby="tab-general"> 79 <div id="content-general" role="tabpanel" aria-labelledby="tab-general">
80 <header> 80 <header>
81 <h1 class="i18n_options_tab_general"></h1> 81 <h1 class="i18n_options_tab_general"></h1>
82 <p class="i18n_options_general_description"></p> 82 <p class="i18n_options_general_description"></p>
83 </header> 83 </header>
84 <section class="cols"> 84 <section class="cols">
85 <h2 class="i18n_options_privacy_header"></h2> 85 <h2 class="i18n_options_privacy_header"></h2>
86 <ul class="list" id="recommend-protection-list-table"> 86 <ul class="list" id="recommend-protection-list-table">
87 <template> 87 <template>
88 <button data-action="toggle-remove-subscription" role="checkbox" c lass="control icon"></button> 88 <button data-action="toggle-remove-subscription" role="checkbox" c lass="control icon"></button>
89 <label class="display"></label> 89 <label data-display="title"></label>
90 <span data-tooltip="options_protection_%value%_tooltip"></span> 90 <span data-tooltip="options_protection_%value%_tooltip"></span>
91 </template> 91 </template>
92 </ul> 92 </ul>
93 </section> 93 </section>
94 <section class="cols"> 94 <section class="cols">
95 <header> 95 <header>
96 <h2 class="i18n_options_acceptableAds_header"></h2> 96 <h2 class="i18n_options_acceptableAds_header"></h2>
97 <p class="i18n_options_acceptableAds_description"></p> 97 <p class="i18n_options_acceptableAds_description"></p>
98 </header> 98 </header>
99 <form id="acceptable-ads"> 99 <form id="acceptable-ads">
(...skipping 27 matching lines...) Expand all
127 </form> 127 </form>
128 </section> 128 </section>
129 <section class="cols"> 129 <section class="cols">
130 <header> 130 <header>
131 <h2 class="i18n_options_language_header"></h2> 131 <h2 class="i18n_options_language_header"></h2>
132 <p class="i18n_options_language_description"></p> 132 <p class="i18n_options_language_description"></p>
133 </header> 133 </header>
134 <div id="blocking-languages"> 134 <div id="blocking-languages">
135 <ul id="blocking-languages-table" class="table list bottom-control"> 135 <ul id="blocking-languages-table" class="table list bottom-control">
136 <template> 136 <template>
137 <label class="display"></label> 137 <label>
ire 2018/01/04 08:32:52 Using the <label> element here (and below) may not
saroyanm 2018/01/04 21:28:52 Agree, done.
138 <span data-display="title"></span>
139 <em>(<span data-display="originalTitle"></span>)</em>
140 </label>
138 <button data-single="hidden" data-action="remove-subscription" c lass="icon delete control" title="options_control_remove_title"></button> 141 <button data-single="hidden" data-action="remove-subscription" c lass="icon delete control" title="options_control_remove_title"></button>
139 <button data-single="visible" data-action="open-dialog" data-dia log="language-change" class="i18n_options_language_change link"></button> 142 <button data-single="visible" data-action="open-dialog" data-dia log="language-change" class="i18n_options_language_change link"></button>
140 </template> 143 </template>
141 </ul> 144 </ul>
142 <button class="i18n_options_language_add list" data-action="open-dia log" data-dialog="language-add"></button> 145 <button class="i18n_options_language_add list" data-action="open-dia log" data-dialog="language-add"></button>
143 <p class="i18n_options_language_tip"></p> 146 <p class="i18n_options_language_tip"></p>
144 </div> 147 </div>
145 </section> 148 </section>
146 <section id="more-filters" class="cols"> 149 <section id="more-filters" class="cols">
147 <header> 150 <header>
148 <h2 class="i18n_options_more_filters_header"></h2> 151 <h2 class="i18n_options_more_filters_header"></h2>
149 <p class="i18n_options_more_filters_description"></p> 152 <p class="i18n_options_more_filters_description"></p>
150 </header> 153 </header>
151 <div> 154 <div>
152 <ul id="more-list-table" class="table list"> 155 <ul id="more-list-table" class="table list">
153 <template> 156 <template>
154 <label class="display"></label> 157 <label data-display="title"></label>
155 <button data-action="remove-subscription" class="i18n_options_co ntrol_remove_title link control" title="options_control_remove_title"></button> 158 <button data-action="remove-subscription" class="i18n_options_co ntrol_remove_title link control" title="options_control_remove_title"></button>
156 </template> 159 </template>
157 </ul> 160 </ul>
158 <p class="i18n_options_more_filters_note"></p> 161 <p class="i18n_options_more_filters_note"></p>
159 </div> 162 </div>
160 </section> 163 </section>
161 </div> 164 </div>
162 165
163 <!-- Whitelist tab content --> 166 <!-- Whitelist tab content -->
164 <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-whitelist "> 167 <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-whitelist ">
165 <header> 168 <header>
166 <h1 class="i18n_options_tab_whitelist"></h1> 169 <h1 class="i18n_options_tab_whitelist"></h1>
167 <p> 170 <p>
168 <span class="i18n_options_whitelist_description"></span> 171 <span class="i18n_options_whitelist_description"></span>
169 <a id="whitelist-learn-more" class="i18n_options_learn_more" target= "_blank"></a> 172 <a id="whitelist-learn-more" class="i18n_options_learn_more" target= "_blank"></a>
170 </p> 173 </p>
171 </header> 174 </header>
172 <form class="section"> 175 <form class="section">
173 <input id="whitelisting-textbox" type="text"> 176 <input id="whitelisting-textbox" type="text">
174 <button id="whitelisting-add-button" 177 <button id="whitelisting-add-button"
175 type="submit" 178 type="submit"
176 data-action="add-domain-exception" 179 data-action="add-domain-exception"
177 class="i18n_options_whitelist_add primary" disabled> 180 class="i18n_options_whitelist_add primary" disabled>
178 </button> 181 </button>
179 </form> 182 </form>
180 <ul id="whitelisting-table" class="table list"> 183 <ul id="whitelisting-table" class="table list">
181 <template> 184 <template>
182 <label class="display"></label> 185 <label data-display="title"></label>
183 <button data-action="remove-filter" class="icon delete control" 186 <button data-action="remove-filter" class="icon delete control"
184 title="options_control_remove_title"> 187 title="options_control_remove_title">
185 </button> 188 </button>
186 </template> 189 </template>
187 </ul> 190 </ul>
188 </div> 191 </div>
189 192
190 <!-- Advanced tab content --> 193 <!-- Advanced tab content -->
191 <div id="content-advanced" role="tabpanel" 194 <div id="content-advanced" role="tabpanel"
192 aria-labelledby="tab-advanced"> 195 aria-labelledby="tab-advanced">
193 <header> 196 <header>
194 <h1 class="i18n_options_tab_advanced"></h1> 197 <h1 class="i18n_options_tab_advanced"></h1>
195 <p class="i18n_options_advanced_description"></p> 198 <p class="i18n_options_advanced_description"></p>
196 </header> 199 </header>
197 <section class="cols"> 200 <section class="cols">
198 <h2 class="i18n_options_customize_header"></h2> 201 <h2 class="i18n_options_customize_header"></h2>
199 <ul id="customize" class="list"> 202 <ul id="customize" class="list">
200 <li data-pref="shouldShowBlockElementMenu"> 203 <li data-pref="shouldShowBlockElementMenu">
201 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> 204 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton>
202 <span class="i18n_options_customize_blockElement display"></span> 205 <label class="i18n_options_customize_blockElement" data-display="t itle"></label>
203 <span data-tooltip="options_customize_blockElement_tooltip"></span > 206 <span data-tooltip="options_customize_blockElement_tooltip"></span >
204 </li> 207 </li>
205 <li data-pref="show_devtools_panel"> 208 <li data-pref="show_devtools_panel">
206 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> 209 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton>
207 <span class="i18n_options_customize_showDevToolsPanel display"></s pan> 210 <span class="i18n_options_customize_showDevToolsPanel" data-displa y="title"></span>
208 <span data-tooltip="options_customize_showDevToolsPanel_tooltip">< /span> 211 <span data-tooltip="options_customize_showDevToolsPanel_tooltip">< /span>
209 </li> 212 </li>
210 <li data-pref="notifications_ignoredcategories"> 213 <li data-pref="notifications_ignoredcategories">
211 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> 214 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton>
212 <span class="i18n_options_customize_showNotifications display"></s pan> 215 <span class="i18n_options_customize_showNotifications" data-displa y="title"></span>
213 <span data-tooltip="options_customize_showNotifications_tooltip">< /span> 216 <span data-tooltip="options_customize_showNotifications_tooltip">< /span>
214 </li> 217 </li>
215 </ul> 218 </ul>
216 </section> 219 </section>
217 220
218 <section> 221 <section>
219 <header> 222 <header>
220 <h2 class="i18n_options_filterList_title"></h2> 223 <h2 class="i18n_options_filterList_title"></h2>
221 <p> 224 <p>
222 <span class="i18n_options_filterList_description"></span> 225 <span class="i18n_options_filterList_description"></span>
(...skipping 12 matching lines...) Expand all
235 <template> 238 <template>
236 <div class="col5"> 239 <div class="col5">
237 <button data-action="toggle-disable-subscription" role="checkbox " class="control icon toggle"> 240 <button data-action="toggle-disable-subscription" role="checkbox " class="control icon toggle">
238 </button> 241 </button>
239 <div class="state"> 242 <div class="state">
240 <span class="i18n_options_filterList_state_active" id="state-a ctive"></span> 243 <span class="i18n_options_filterList_state_active" id="state-a ctive"></span>
241 <span class="i18n_options_filterList_state_disabled" id="state -disabled"></span> 244 <span class="i18n_options_filterList_state_disabled" id="state -disabled"></span>
242 </div> 245 </div>
243 </div> 246 </div>
244 <div class="col5"> 247 <div class="col5">
245 <label class="display"></label> 248 <label data-display="originalTitle"></label>
246 </div> 249 </div>
247 <div class="col5"> 250 <div class="col5">
248 <span class="last-update"></span> 251 <span class="last-update"></span>
249 <span class="message"></span> 252 <span class="message"></span>
250 </div> 253 </div>
251 <div class="col5"> 254 <div class="col5">
252 <button data-action="open-context-menu" class="icon gear"></butt on> 255 <button data-action="open-context-menu" class="icon gear"></butt on>
253 <div role="menubar" class="context-menu-wrapper"> 256 <div role="menubar" class="context-menu-wrapper">
254 <div class="context-menu"> 257 <div class="context-menu">
255 <ul class="content" role="menu"> 258 <ul class="content" role="menu">
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 <p class="i18n_options_dialog_about_trademark"></p> 367 <p class="i18n_options_dialog_about_trademark"></p>
365 <p> 368 <p>
366 <button class="i18n_options_close primary default-focus" data-action ="close-dialog"></button> 369 <button class="i18n_options_close primary default-focus" data-action ="close-dialog"></button>
367 </p> 370 </p>
368 </div> 371 </div>
369 <!-- Add language subscription --> 372 <!-- Add language subscription -->
370 <div id="dialog-content-language-add" class="dialog-content"> 373 <div id="dialog-content-language-add" class="dialog-content">
371 <ul id="all-lang-table-add" class="table list default-focus"> 374 <ul id="all-lang-table-add" class="table list default-focus">
372 <template> 375 <template>
373 <button data-action="add-language-subscription,close-dialog" class ="control icon add" role="checkbox"> 376 <button data-action="add-language-subscription,close-dialog" class ="control icon add" role="checkbox">
374 <label class="display"></label> 377 <label>
ire 2018/01/04 08:32:52 As I mentioned above the <label> here isn't approp
saroyanm 2018/01/04 21:28:52 Agree, done.
378 <span data-display="title"></span>
379 <em>(<span data-display="originalTitle"></span>)</em>
ire 2018/01/04 08:32:52 Should this be an `<em>` element? In the spec scre
saroyanm 2018/01/04 21:28:52 Initially I though we would like to <em> as stress
380 </label>
375 </button> 381 </button>
376 <button data-action="change-language-subscription,close-dialog" cl ass="control icon change" role="checkbox"> 382 <button data-action="change-language-subscription,close-dialog" cl ass="control icon change" role="checkbox">
377 <label class="display"></label> 383 <label>
384 <span data-display="title"></span>
385 <em>(<span data-display="originalTitle"></span>)</em>
386 </label>
378 </button> 387 </button>
379 </template> 388 </template>
380 </ul> 389 </ul>
381 </div> 390 </div>
382 <!-- Add import subscription --> 391 <!-- Add import subscription -->
383 <div id="dialog-content-import" class="dialog-content"> 392 <div id="dialog-content-import" class="dialog-content">
384 <form data-validation="custom" novalidate> 393 <form data-validation="custom" novalidate>
385 <p class="floating-input"> 394 <p class="floating-input">
386 <input placeholder=" " id="import-list-title" type="text" class="d efault-focus" required /> 395 <input placeholder=" " id="import-list-title" type="text" class="d efault-focus" required />
387 <label for="import-list-title" class="i18n_options_dialog_import_s ubscription_title"></label> 396 <label for="import-list-title" class="i18n_options_dialog_import_s ubscription_title"></label>
(...skipping 26 matching lines...) Expand all
414 </div> 423 </div>
415 <!-- Notification --> 424 <!-- Notification -->
416 <div id="notification" aria-hidden="true" aria-live="polite"> 425 <div id="notification" aria-hidden="true" aria-live="polite">
417 <strong id="notification-text"></strong> 426 <strong id="notification-text"></strong>
418 <button class="icon close secondary" data-action="hide-notification"> 427 <button class="icon close secondary" data-action="hide-notification">
419 <span class="i18n_options_notification_hide sr-only"></span> 428 <span class="i18n_options_notification_hide sr-only"></span>
420 </button> 429 </button>
421 </div> 430 </div>
422 </body> 431 </body>
423 </html> 432 </html>
OLDNEW
« no previous file with comments | « no previous file | desktop-options.js » ('j') | desktop-options.js » ('J')

Powered by Google App Engine
This is Rietveld