Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/blog/index.md

Issue 29657629: Issue 6211 - Fixed size of blog post thumbnails on mobile (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Created Jan. 5, 2018, 2:46 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « includes/blog/all-posts.tmpl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title=Blog | Acceptable Ads 1 title=Blog | Acceptable Ads
2 description=Keeping you up-to-date with everything related to acceptable ads. 2 description=Keeping you up-to-date with everything related to acceptable ads.
3 breadcrumb=Blog 3 breadcrumb=Blog
4 custom=1 4 custom=1
5 5
6 <style> 6 <style>
7 .card h3 7 .card h3
8 { 8 {
9 font-size: 20px; 9 font-size: 20px;
10 height: 70px; 10 height: 70px;
11 } 11 }
12 12
13 .card img
14 {
15 display: block;
16 margin: 0 auto;
17 }
18
19 @media (max-width: 766px)
ire 2018/01/08 10:58:44 Should be 767px
juliandoucette 2018/01/08 12:45:36 Good catch.
20 {
21 .card a,
ire 2018/01/08 10:58:43 Why is there a fixed height on the links as well?
juliandoucette 2018/01/08 12:45:36 No idea :/
22 .card img { height: 200px; }
ire 2018/01/08 10:58:43 This isn't relevant now (because most images are a
ire 2018/01/08 10:58:43 I don't think the single-line format should be use
juliandoucette 2018/01/08 12:45:36 Good catch.
juliandoucette 2018/01/08 12:45:36 Not sure about this :/ (It won't be relevant in t
ire 2018/01/09 08:26:33 Are you going to address this now?
juliandoucette 2018/01/09 14:24:03 I thought I did :D Should be addressed now.
23 }
24
13 @media(min-width: 768px) 25 @media(min-width: 768px)
14 { 26 {
15 .card img.block 27 .card img { max-height: 100px; }
ire 2018/01/08 10:58:44 NIT: Maybe this should just be height instead of m
juliandoucette 2018/01/08 12:45:36 I think max-height is better if height/width are a
16 {
17 width: auto !important;
18 height: auto;
19 max-height: 100px;
20 margin: 0 auto;
21 }
22 } 28 }
23 </style> 29 </style>
24 30
25 <div class="container" markdown="1"> 31 <div class="container" markdown="1">
26 # {{blog-heading[Blog Heading] The official Acceptable Ads blog}} 32 # {{blog-heading[Blog Heading] The official Acceptable Ads blog}}
27 33
28 --- 34 ---
29 35
30 <div class="section" markdown="1"> 36 <div class="section" markdown="1">
31 {{blog-paragraph1[Acceptable Ads Blog Paragraph 1] Stay connected.}} 37 {{blog-paragraph1[Acceptable Ads Blog Paragraph 1] Stay connected.}}
32 </div> 38 </div>
33 39
34 </div> 40 </div>
35 41
36 <? include blog/all-posts ?> 42 <? include blog/all-posts ?>
OLDNEW
« no previous file with comments | « includes/blog/all-posts.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld