Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/blog/index.md

Issue 29657629: Issue 6211 - Fixed size of blog post thumbnails on mobile (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Left Patch Set: Created Jan. 5, 2018, 2:46 p.m.
Right Patch Set: Addressed #5 Created Jan. 9, 2018, 2:22 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/blog/all-posts.tmpl ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Blog | Acceptable Ads 1 title=Blog | Acceptable Ads
2 description=Keeping you up-to-date with everything related to acceptable ads. 2 description=Keeping you up-to-date with everything related to acceptable ads.
3 breadcrumb=Blog 3 breadcrumb=Blog
4 custom=1 4 custom=1
5 5
6 <style> 6 <style>
7 .card h3 7 .card h3
8 { 8 {
9 font-size: 20px; 9 font-size: 20px;
10 height: 70px;
11 } 10 }
12 11
13 .card img 12 .card img
14 { 13 {
15 display: block; 14 display: block;
15 height: auto;
16 max-height: 200px;
17 width: auto;
18 max-width: 100%;
16 margin: 0 auto; 19 margin: 0 auto;
17 }
18
19 @media (max-width: 766px)
ire 2018/01/08 10:58:44 Should be 767px
juliandoucette 2018/01/08 12:45:36 Good catch.
20 {
21 .card a,
ire 2018/01/08 10:58:43 Why is there a fixed height on the links as well?
juliandoucette 2018/01/08 12:45:36 No idea :/
22 .card img { height: 200px; }
ire 2018/01/08 10:58:43 This isn't relevant now (because most images are a
ire 2018/01/08 10:58:43 I don't think the single-line format should be use
juliandoucette 2018/01/08 12:45:36 Good catch.
juliandoucette 2018/01/08 12:45:36 Not sure about this :/ (It won't be relevant in t
ire 2018/01/09 08:26:33 Are you going to address this now?
juliandoucette 2018/01/09 14:24:03 I thought I did :D Should be addressed now.
23 } 20 }
24 21
25 @media(min-width: 768px) 22 @media(min-width: 768px)
26 { 23 {
24 .card h3 { height: 70px; }
ire 2018/01/10 10:08:39 Why is this here? (This height doesn't actually co
juliandoucette 2018/01/11 12:43:56 I knew this would come back to bite me :D This is
ire 2018/01/12 12:44:46 Haha ack. I don't think it is particularly helpful
27 .card img { max-height: 100px; } 25 .card img { max-height: 100px; }
ire 2018/01/08 10:58:44 NIT: Maybe this should just be height instead of m
juliandoucette 2018/01/08 12:45:36 I think max-height is better if height/width are a
28 } 26 }
29 </style> 27 </style>
30 28
31 <div class="container" markdown="1"> 29 <div class="container" markdown="1">
32 # {{blog-heading[Blog Heading] The official Acceptable Ads blog}} 30 # {{blog-heading[Blog Heading] The official Acceptable Ads blog}}
33 31
34 --- 32 ---
35 33
36 <div class="section" markdown="1"> 34 <div class="section" markdown="1">
37 {{blog-paragraph1[Acceptable Ads Blog Paragraph 1] Stay connected.}} 35 {{blog-paragraph1[Acceptable Ads Blog Paragraph 1] Stay connected.}}
38 </div> 36 </div>
39 37
40 </div> 38 </div>
41 39
42 <? include blog/all-posts ?> 40 <? include blog/all-posts ?>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld