Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/blog/index.md

Issue 29657629: Issue 6211 - Fixed size of blog post thumbnails on mobile (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Created Jan. 5, 2018, 2:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « includes/blog/all-posts.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/blog/index.md
===================================================================
--- a/pages/blog/index.md
+++ b/pages/blog/index.md
@@ -5,25 +5,31 @@
<style>
.card h3
{
font-size: 20px;
height: 70px;
}
+.card img
+{
+ display: block;
+ margin: 0 auto;
+}
+
+@media (max-width: 766px)
ire 2018/01/08 10:58:44 Should be 767px
juliandoucette 2018/01/08 12:45:36 Good catch.
+{
+ .card a,
ire 2018/01/08 10:58:43 Why is there a fixed height on the links as well?
juliandoucette 2018/01/08 12:45:36 No idea :/
+ .card img { height: 200px; }
ire 2018/01/08 10:58:43 This isn't relevant now (because most images are a
ire 2018/01/08 10:58:43 I don't think the single-line format should be use
juliandoucette 2018/01/08 12:45:36 Good catch.
juliandoucette 2018/01/08 12:45:36 Not sure about this :/ (It won't be relevant in t
ire 2018/01/09 08:26:33 Are you going to address this now?
juliandoucette 2018/01/09 14:24:03 I thought I did :D Should be addressed now.
+}
+
@media(min-width: 768px)
{
- .card img.block
- {
- width: auto !important;
- height: auto;
- max-height: 100px;
- margin: 0 auto;
- }
+ .card img { max-height: 100px; }
ire 2018/01/08 10:58:44 NIT: Maybe this should just be height instead of m
juliandoucette 2018/01/08 12:45:36 I think max-height is better if height/width are a
}
</style>
<div class="container" markdown="1">
# {{blog-heading[Blog Heading] The official Acceptable Ads blog}}
---
« no previous file with comments | « includes/blog/all-posts.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld