Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 29657633: Issue 6188 - Add-ons option is being shown (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by diegocarloslima
Modified:
6 months ago
Reviewers:
anton, jens
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6188 - Add-ons option is being shown

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M mobile/android/app/src/main/res/menu-large/browser_app_menu.xml View 1 chunk +0 lines, -1 line 1 comment Download
M mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml View 1 chunk +0 lines, -1 line 0 comments Download
M mobile/android/app/src/main/res/menu/browser_app_menu.xml View 1 chunk +0 lines, -1 line 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/BrowserApp.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
diegocarloslima
https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml File mobile/android/app/src/main/res/menu-large/browser_app_menu.xml (left): https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml#oldcode101 mobile/android/app/src/main/res/menu-large/browser_app_menu.xml:101: android:visible="false" Since we're forcing add-ons to be hidden in ...
6 months, 2 weeks ago (2018-01-05 20:46:26 UTC) #1
anton
On 2018/01/05 20:46:26, diegocarloslima wrote: > https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml > File mobile/android/app/src/main/res/menu-large/browser_app_menu.xml (left): > > https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/src/main/res/menu-large/browser_app_menu.xml#oldcode101 > ...
6 months, 1 week ago (2018-01-09 06:41:29 UTC) #2
jens
6 months, 1 week ago (2018-01-10 11:26:45 UTC) #3
On 2018/01/09 06:41:29, anton wrote:
> On 2018/01/05 20:46:26, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/...
> > File mobile/android/app/src/main/res/menu-large/browser_app_menu.xml (left):
> > 
> >
>
https://codereview.adblockplus.org/29657633/diff/29657634/mobile/android/app/...
> > mobile/android/app/src/main/res/menu-large/browser_app_menu.xml:101:
> > android:visible="false"
> > Since we're forcing add-ons to be hidden in BrowserApp.java, we can revert
the
> > changes we previously made in browser_app_menu.xml
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5