skin/icons/checkbox.svg - Issue 29659594: Issue 6089 - Adjusted checkbox cut borders

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/icons/checkbox.svg

Issue 29659594: Issue 6089 - Adjusted checkbox cut borders (Closed)

Patch Set: Created Jan. 8, 2018, 3:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 <svg xmlns="http://www.w3.org/2000/svg">	1 <svg xmlns="http://www.w3.org/2000/svg">

2 <view id="on" viewBox="0 0 18 18"/>	2 <view id="on" viewBox="0 0 18 18"/>

3 <g fill="none" fill-rule="evenodd">	3 <g fill="none" fill-rule="evenodd">

4 <rect width="18" height="18" fill="#077CA6" stroke="#077CA6" rx="2"/>	4 <rect width="17" height="17" fill="#077CA6" stroke="#077CA6" rx="2" x=".5" y =".5" />
	saroyanm 2018/01/08 15:14:26 I adjusted the size to be consistent with the "off I adjusted the size to be consistent with the "off" button which appears to fix the border issue. ire 2018/01/09 08:38:00 Acknowledged. Show quoted text On 2018/01/08 15:14:26, saroyanm wrote: > I adjusted the size to be consistent with the "off" button which appears to fix > the border issue. Acknowledged.
5 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>	5 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>

6 </g>	6 </g>

7	7

8 <view id="off" viewBox="0 18 18 18"/>	8 <view id="off" viewBox="0 18 18 18"/>

9 <rect width="17" height="17" x=".5" y="18.5" fill="none" stroke="#000" rx="2"/ >	9 <rect width="17" height="17" x=".5" y="18.5" fill="none" stroke="#000" rx="2"/ >

10 </svg>	10 </svg>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »