Issue 6231 - Add tests for translation string substitution

cms/sources.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 129 matching lines @@
     def has_static(self, filename):
         return self.has_file(self.static_filename(filename))
 
     def read_static(self, filename):
         return self.read_file(self.static_filename(filename), binary=True)[0]
 
     #
     # Locale helpers
     #
 
-    @classmethod
-    def locale_filename(cls, locale, page):
-        return cls.localizable_file_filename(locale, page + '.json')
+    def locale_filename(self, locale, page):
+        config = self.read_config()

[Vasily Kuznetsov, 2018/01/12 19:56:49]

Unfortunately I had to also make this substantive change -- without it
translation overrides only partially work. I hope nothing depends on this
partial working -- will need to test it before pushing this.

[Jon Sonesen, 2018/01/19 04:45:37]

Hm, I have played with it a fair amount and it seems legit. However, I have not
generated all of our sites and checked the locale string insertions for issues.

[Vasily Kuznetsov, 2018/01/19 15:34:29]

Checked on help.eyeo.com, web.acceptableads.org, web.adblockplus.org,
web.acceptableads.com, web.adblockbrowser.org and web.eyeo.com. The results are
identical.

+        try:
+            page = config.get('locale_overrides', page)
+        except ConfigParser.Error:
+            pass
+        return self.localizable_file_filename(locale, page + '.json')
 
     def list_locales(self):
         result = set()
         for filename in self.list_files('locales'):
             if '/' in filename:
                 locale, path = filename.split('/', 1)
                 result.add(locale)
         return result
 
     def has_locale(self, locale, page):
-        config = self.read_config()
-        try:
-            page = config.get('locale_overrides', page)
-        except ConfigParser.Error:
-            pass
         return self.has_file(self.locale_filename(locale, page))
 
     def read_locale(self, locale, page):
         default_locale = self.read_config().get('general', 'defaultlocale')
         result = collections.OrderedDict()
         if locale != default_locale:
             result.update(self.read_locale(default_locale, page))
 
         if self.has_locale(locale, page):
             filename = self.locale_filename(locale, page)
@@ skipping 273 matching lines @@
             'resolve_link',
             'read_config',
             'read_template',
             'read_locale',
             'read_include',
             'exec_file',
         ]:
             setattr(source, fname, _memoize(getattr(source, fname)))
 
     return source