Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(694)

Issue 29661608: Issue 6241 - Allow a native build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by hub
Modified:
6 months ago
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6241 - Allow a native build.

Patch Set 1 #

Total comments: 13

Patch Set 2 : addressed comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -79 lines) Patch
M README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A compiled/Utils.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A compiled/Utils.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download
A compiled/library.cpp View 1 1 chunk +76 lines, -0 lines 2 comments Download
M meson.build View 1 3 chunks +111 lines, -79 lines 0 comments Download
M meson_options.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
hub
6 months, 1 week ago (2018-01-10 21:26:15 UTC) #1
sergei
Good, I'm mainly concerned about ID of regular expressions and from_string. https://codereview.adblockplus.org/29661608/diff/29661609/compiled/library.cpp File compiled/library.cpp (right): ...
6 months, 1 week ago (2018-01-11 08:54:07 UTC) #2
hub
https://codereview.adblockplus.org/29661608/diff/29661609/compiled/library.cpp File compiled/library.cpp (right): https://codereview.adblockplus.org/29661608/diff/29661609/compiled/library.cpp#newcode42 compiled/library.cpp:42: std::vector<std::unique_ptr<std::wregex>> mRegexPool; On 2018/01/11 08:54:06, sergei wrote: > BTW, ...
6 months, 1 week ago (2018-01-11 20:41:28 UTC) #3
sergei
https://codereview.adblockplus.org/29661608/diff/29661609/compiled/library.cpp File compiled/library.cpp (right): https://codereview.adblockplus.org/29661608/diff/29661609/compiled/library.cpp#newcode48 compiled/library.cpp:48: s.push_back(str[idx]); On 2018/01/11 20:41:27, hub wrote: > On 2018/01/11 ...
6 months, 1 week ago (2018-01-12 09:58:12 UTC) #4
hub
https://codereview.adblockplus.org/29661608/diff/29663576/compiled/library.cpp File compiled/library.cpp (right): https://codereview.adblockplus.org/29661608/diff/29663576/compiled/library.cpp#newcode45 compiled/library.cpp:45: std::vector<std::unique_ptr<std::wregex>> regexPool; On 2018/01/12 09:58:12, sergei wrote: > I ...
6 months, 1 week ago (2018-01-12 14:33:53 UTC) #5
sergei
6 months ago (2018-01-15 10:50:42 UTC) #6
I have files a couple of issues regarding this codereview.
https://issues.adblockplus.org/ticket/6266
https://issues.adblockplus.org/ticket/6267

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5