.travis.yml - Issue 29663680: Issue 6220 - add travis-ci configuration for adblockpluscore

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .travis.yml

Issue 29663680: Issue 6220 - add travis-ci configuration for adblockpluscore (Closed) Base URL: github.com:adblockplus/adblockpluscore

Patch Set: Created Jan. 11, 2018, 9:28 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 language: cpp
	sergei 2018/01/11 21:53:13 The language is cpp because it will simplify it wh The language is cpp because it will simplify it when we start to compile emscripten code for native applications.
	2

	3 os:

	4 - linux

	5 - osx

	6

	7 dist: trusty

	8

	9 python: '2.7'

	10

	11 install:

	12 - nvm install 8.9.4
	sergei 2018/01/11 21:53:13 current latest LTS, For the beginning IMO it's eno current latest LTS, For the beginning IMO it's enough, however we should actually test against several versions, e.g. the versions of V8 which are used in chrome browsers which supported by our extension.
	13

	14 before_script:

	15 - ./ensure_dependencies.py

	16 - npm install

	17

	18 script:

	19 - npm test

	20

	21 notifications:

	22 email: false
	tlucas 2018/01/17 12:41:40 Do we not want to be notified about failed builds? Do we not want to be notified about failed builds? Also, FWIW we could add some sugar and notify #adblockplus about succeeded builds ;) sergei 2018/01/17 14:25:30 Just would like to precise that it can be configur Show quoted text On 2018/01/17 12:41:39, tlucas wrote: > Do we not want to be notified about failed builds? Just would like to precise that it can be configured whether it's for failed builds or even always. Show quoted text > Also, FWIW we could add some sugar and notify #adblockplus about succeeded > builds ;) This looks attractive actually, perhaps we should add it, I modified the issue description. IMO we should keep it silent for the beginning until we see that it is working smoothly and see that we really need such information. I have some experience with such notifications, usually e-mail notifications become a spam pretty soon, so I would propose to disable them and drop a message in IRC channel. In addition we should take into account the actual workflow, unfortunately we don't push too often to the main repository, and we are more or less aware when it happens (at least I'm notified in IRC by corresponding keywords) and can track the CI status, on the other hand the default configuration should not bother IMO us nor the author of changes. Let's say I am a third party person (or even I'm who I'm) and want to contribute, in order to do it I fork the repo, make some changes and before sending it to codereview I run CI for the fork, and this CI should not send any e-mail to anybody but me (if I really want it) nor send anything to IRC.
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »