.travis/prepare-ninja.sh - Issue 29663688: Issue 6220 - add travis-ci configuration for adblockpluscore

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .travis/prepare-ninja.sh

Issue 29663688: Issue 6220 - add travis-ci configuration for adblockpluscore (Closed) Base URL: github.com:adblockplus/adblockpluscore

Patch Set: Created Jan. 11, 2018, 9:33 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #!/usr/bin/env bash

	2

	3 set -x

	4 set -e

	5

	6 if [[ "$TRAVIS_OS_NAME" = "osx" ]]; then

	7 brew update; brew install ninja;

	8 else

	9 wget https://github.com/ninja-build/ninja/releases/download/v1.8.2/ninja-linux.z ip -O third_party/ninja-build.zip
	sergei 2018/01/11 22:04:09 It's again #6200, the version which is installed v It's again #6200, the version which is installed via apt-get by default is too old (1.3.4 in case of travis-ci), meson requires at least 1.5 or newer.
	10 mkdir third_party/ninja

	11 unzip third_party/ninja-build.zip -d third_party/ninja
	tlucas 2018/01/17 12:41:39 Please help me out here - can we be sure, that "un Please help me out here - can we be sure, that "unzip" is always given? If not, you might want to add it to the "install"-section in .travis.yml sergei 2018/01/17 14:26:25 As far as I know travis-ci servers usually include Show quoted text On 2018/01/17 12:41:39, tlucas wrote: > Please help me out here - can we be sure, that "unzip" is always given? If not, > you might want to add it to the "install"-section in .travis.yml As far as I know travis-ci servers usually include a plenty of already installed tools which can be absent on a fresh linux, in our case they are at least wget, unzip and nvm. Since we are targeting only travis-ci here, I think we should not include those tools because otherwise we would have to include a long list of tools (just imagine how difficult to follow this convention with android builds).
	12 fi

OLD	NEW

« .travis.yml ('K') | « .travis/prepare-emscripten.sh ('k') | no next file » | no next file with comments »