Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 29664569: Favicon: Issue 6245 - SwiftLinted project files

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by a.shephard
Modified:
3 days, 17 hours ago
Reviewers:
d108, dean
Visibility:
Public.

Description

Favicon: Issue 6245 - SwiftLinted project files

Patch Set 1 #

Patch Set 2 : Favicon: Issue 6245 - SwiftLinted project files #

Patch Set 3 : Favicon: Issue 6245 - Swiftlinted project files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -343 lines) Patch
M .swiftlint.yml View 1 2 1 chunk +26 lines, -5 lines 0 comments Download
M FavIcon/DetectedIcon.swift View 2 chunks +4 lines, -2 lines 0 comments Download
M FavIcon/FavIcon.swift View 1 18 chunks +56 lines, -47 lines 0 comments Download
M FavIcon/IconExtraction.swift View 1 7 chunks +217 lines, -236 lines 0 comments Download
M FavIcon/URLRequestOperation.swift View 3 chunks +9 lines, -7 lines 0 comments Download
M FavIcon/Utils.swift View 2 chunks +36 lines, -20 lines 0 comments Download
M FavIconTests/FavIconsTests.swift View 1 4 chunks +5 lines, -7 lines 0 comments Download
M FavIconTests/HTMLDocumentTests.swift View 1 chunk +1 line, -1 line 0 comments Download
M Walkthrough.playground/Contents.swift View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 3
a.shephard
1 week ago (2018-01-12 11:05:17 UTC) #1
a.shephard
Updated w/ new patchset containing more linting.
1 week ago (2018-01-12 16:51:20 UTC) #2
dean
1 week ago (2018-01-13 00:43:57 UTC) #3
On 2018/01/12 16:51:20, a.shephard wrote:
> Updated w/ new patchset containing more linting.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5