Issue 29664601: Issue 6212 - Don't create reports for type "other"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29664601: Issue 6212 - Don't create reports for type "other" (Closed)

Created:
Jan. 12, 2018, 11:58 a.m. by tlucas

Modified:
April 11, 2018, 12:55 p.m.

Reviewers:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/sitescripts/file/cd6f20a3aede

Visibility:
Public.

Description

Issue 6212 - Don't create reports for type "other"

Patch Set 1 #

Created: Jan. 12, 2018, 11:58 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	sitescripts/reports/bin/mailDigests.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tlucas

Patch Set 1 * Removed the "other"-branch in reports generation

Jan. 12, 2018, 11:59 a.m. (2018-01-12 11:59:40 UTC) #1

Vasily Kuznetsov

On 2018/01/12 11:59:40, tlucas wrote: > Patch Set 1 > > * Removed the "other"-branch ...

Jan. 12, 2018, 7:51 p.m. (2018-01-12 19:51:54 UTC) #2

tlucas

Jan. 26, 2018, 3:56 p.m. (2018-01-26 15:56:28 UTC) #3

On 2018/01/12 19:51:54, Vasily Kuznetsov wrote:
> On 2018/01/12 11:59:40, tlucas wrote:
> > Patch Set 1
> > 
> > * Removed the "other"-branch in reports generation
> 
> Assuming you've tested it, LGTM.

This is actually quite hard to test, without any data. I guess i'll have to
reach out to somebody able to provide me some data, in order to test this

Expand All Messages | Collapse All Messages