Issue 6212 - Don't create reports for type "other"

sitescripts/reports/bin/mailDigests.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 50 matching lines @@
         if dbreport['type'] == 'false positive' or dbreport['type'] == 'false negative':
             for subscription in reportSubscriptions:
                 subscriptionID = subscription.get('url', 'unknown')
                 if subscriptionID in subscriptions:
                     if subscription.get('hasmatches', 0) > 0:
                         matchSubscriptions[subscriptionID] = subscriptions[subscriptionID]
                     # Send false negatives to all subscription authors, false positives
                     # only to subscriptions with matching filters
                     if dbreport['type'] == 'false negative' or subscription.get('hasmatches', 0) > 0:
                         recipients.append(subscriptions[subscriptionID])
-        elif interval != 'week':
-            # Send type "other" to fake subscription - daily reports
-            recipients.append(fakeSubscription)
-            subscriptionID = fakeSubscription.get('url', 'unknown')
 
         if len(recipients) == 0:
             continue
 
         report = {
             'url': get_config().get('reports', 'urlRoot') + dbreport['guid'] + '#secret=' + calculateReportSecret(dbreport['guid']),
             'weight': calculateReportWeight(dbreport, reportSubscriptions),
             'site': dbreport['site'],
             'subscriptions': recipients,
             'comment': re.sub(r'[\x00-\x20]', r' ', dbreport['comment']) if dbreport['comment'] != None else '',
@@ skipping 100 matching lines @@
     if interval == 'week':
         startTime = currentTime - 7 * 24 * 60 * 60
     elif interval == 'day':
         startTime = currentTime - 24 * 60 * 60
 
     fakeSubscription = {'url': 'https://fake.adblockplus.org', 'name': get_config().get('reports', 'defaultSubscriptionName'), 'email': get_config().get('reports', 'defaultSubscriptionRecipient')}
     subscriptions, subscriptionList = loadSubscriptions()
     subscriptionList.append(fakeSubscription)
     reports = scanReports()
     sendNotifications(reports)