Issue 6403 - Updated adblockplusui dependency

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 137 matching lines @@
 
 /**
  * Whether notification opt-out UI should be shown.
  * @type {boolean}
  */
 defaults.notifications_showui = false;
 
 /**
  * Whether to show tracking warning in options page when both
  * Acceptable Ads and subscription of type "Privacy" are enabled.
  * 

[kzar, 2018/01/15 11:58:35]

Could you do me a favour and delete the trailing whitespace here as well? I just
spotted it whilst reviewing your changes.

[Thomas Greiner, 2018/01/17 18:00:06]

Done.

  * @type {boolean}
  */
 defaults.ui_warn_tracking = true;
 
 /**
  * Determines whether data has been cleaned up after upgrading from the legacy
  * extension on Firefox.
  *
  * @type {boolean}
  */
 defaults.data_cleanup_done = false;
 
 /**
  * Notification categories to be ignored.
  *
  * @type {string[]}
  */
 defaults.notifications_ignoredcategories = [];
 
 /**
  * Whether to show the developer tools panel.
  *
  * @type {boolean}
  */
 defaults.show_devtools_panel = true;
 
 /**
  * Whether to suppress the first run page. This preference isn't

[kzar, 2018/01/15 11:58:35]

Mind updating this comment since the preference also suppresses the updates page
now as well. Also please could you update the issue to mention this change and
the Hints for testers section to add a note to test that the preference works.

[Thomas Greiner, 2018/01/17 18:00:05]

Done. Good point.

Posted it as a comment in the ticket but since nobody replied there I must've
missed to update the ticket description.

  * set by the extension but can be pre-configured externally.
  *
  * @see https://adblockplus.org/development-builds/suppressing-the-first-run-page-on-chrome
  * @type {boolean}
  */
 defaults.suppress_first_run_page = false;
 
 /**
  * Additonal subscriptions to be automatically added when the extension is
  * loaded. This preference isn't set by the extension but can be pre-configured
  * externally.
  *
  * @type {string[]}
  */
 defaults.additional_subscriptions = [];
 
 /**
+ * The version of major updates that the user is aware of. If it's too low,

[Thomas Greiner, 2018/01/12 16:33:39]

I'm aware that "version of major updates" might sound a bit confusing so if you
have any suggestions, please let me know.

[kzar, 2018/01/15 11:58:35]

How about something like this? "With some major releases an update page is
featured which explains any new functionality to the user. This preferences
contains the most recent version of the extension for which the user has seen an
update page."

[Thomas Greiner, 2018/01/17 18:00:05]

Problem is it doesn't reflect the "most recent version of the extension" but the
version of the updates page which is independent of the extension version.

But I guess its meaning depends on the outcome of the discussion we're having in
the other comment.

+ * the updates page will be shown to inform the user about intermediate changes.
+ *
+ * @type {number}
+ */
+defaults.lastUpdatesVersion = 0;

[kzar, 2018/01/15 11:58:35]

Other preferences names seem to mostly use snake casing (well 4 out of 28 use
camelCasing), also I think the name is a little confusing. How about
`updates_page_seen` or `update_page_seen_version`?

[kzar, 2018/01/15 11:58:35]

I guess the default value should be "0.0.0" with my other suggestions.

[Thomas Greiner, 2018/01/17 18:00:06]

It'd be great if we could make those consistent in the future but yeah, let's
strive towards the most commonly used format. Done.

Note that I also removed the "last" prefix because it seemed unnecessary.

[Thomas Greiner, 2018/01/17 18:00:06]

Yep, it would need to be. Let's come back to this when we concluded the
discussion there.

+
+/**
   * @namespace
   * @static
   */
 let Prefs = exports.Prefs = {
   /**
    * Adds a callback that is called when the
    * value of a specified preference changed.
    *
    * @param {string}   preference
    * @param {function} callback
@@ skipping 158 matching lines @@
           eventEmitter.emit(pref);
         }
       }
     });
   }
 
   Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded);
 }
 
 init();