Issue 6403 - Updated adblockplusui dependency

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 137 matching lines @@
 
 /**
  * Whether notification opt-out UI should be shown.
  * @type {boolean}
  */
 defaults.notifications_showui = false;
 
 /**
  * Whether to show tracking warning in options page when both
  * Acceptable Ads and subscription of type "Privacy" are enabled.
- * 
+ *
  * @type {boolean}
  */
 defaults.ui_warn_tracking = true;
 
 /**
  * Determines whether data has been cleaned up after upgrading from the legacy
  * extension on Firefox.
  *
  * @type {boolean}
  */
 defaults.data_cleanup_done = false;
 
 /**
  * Notification categories to be ignored.
  *
  * @type {string[]}
  */
 defaults.notifications_ignoredcategories = [];
 
 /**
  * Whether to show the developer tools panel.
  *
  * @type {boolean}
  */
 defaults.show_devtools_panel = true;
 
 /**
- * Whether to suppress the first run page. This preference isn't
+ * Whether to suppress the first run and updates page. This preference isn't
  * set by the extension but can be pre-configured externally.
  *
  * @see https://adblockplus.org/development-builds/suppressing-the-first-run-page-on-chrome
  * @type {boolean}
  */
 defaults.suppress_first_run_page = false;
 
 /**
  * Additonal subscriptions to be automatically added when the extension is
  * loaded. This preference isn't set by the extension but can be pre-configured
  * externally.
  *
  * @type {string[]}
  */
 defaults.additional_subscriptions = [];
 
 /**
+ * The version of major updates that the user is aware of. If it's too low,
+ * the updates page will be shown to inform the user about intermediate changes.
+ *
+ * @type {number}
+ */
+defaults.updates_version = 0;

[kzar, 2018/01/23 10:07:13]

I think this preference name is kind of confusing, especially since we call the
version of the current update's page updatesVersion. Without the (very useful)
comment above I would be quite confused about what the preference did. How about
we call it last_update_page_displayed and the other variable updatePageVersion?

[Thomas Greiner, 2018/01/25 11:09:45]

I see your point. Just a bit hesitant to make it too specific to the updates
page or otherwise we'd end up with the same issue as with
"suppress_first_run_page" which we're now using also for the updates page. If we
had used a more generic name (e.g. "suppress_info_pages") would've helped us in
that regard.

So what about something along the lines of "updates_awareness" instead to make
it a bit clearer what it's supposed to represent?

Anyway, if you don't think that being too specific to the updates page is an
issue, I'd be happy to change it to "last_update_page_displayed" as you
suggested.

[kzar, 2018/01/25 11:46:25]

Well it was unfortunate about the "suppress_first_run_page" name you're right
but I think being vague when naming this preference as a response is a bad idea.
I'd rather we went with something like "last_update_page_displayed" that was
easy to understand.

[Thomas Greiner, 2018/01/25 13:09:03]

Done.

+
+/**
   * @namespace
   * @static
   */
 let Prefs = exports.Prefs = {
   /**
    * Adds a callback that is called when the
    * value of a specified preference changed.
    *
    * @param {string}   preference
    * @param {function} callback
@@ skipping 158 matching lines @@
           eventEmitter.emit(pref);
         }
       }
     });
   }
 
   Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded);
 }
 
 init();