Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/prefs.js

Issue 29664623: Issue 6403 - Updated adblockplusui dependency (Closed)
Left Patch Set: Moved updatesVersion to adblockplusui Created Jan. 22, 2018, 4:49 p.m.
Right Patch Set: Created Feb. 23, 2018, 11:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « dependencies ('k') | lib/subscriptionInit.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 * @type {string[]} 199 * @type {string[]}
200 */ 200 */
201 defaults.additional_subscriptions = []; 201 defaults.additional_subscriptions = [];
202 202
203 /** 203 /**
204 * The version of major updates that the user is aware of. If it's too low, 204 * The version of major updates that the user is aware of. If it's too low,
205 * the updates page will be shown to inform the user about intermediate changes. 205 * the updates page will be shown to inform the user about intermediate changes.
206 * 206 *
207 * @type {number} 207 * @type {number}
208 */ 208 */
209 defaults.updates_version = 0; 209 defaults.last_updates_page_displayed = 0;
kzar 2018/01/23 10:07:13 I think this preference name is kind of confusing,
Thomas Greiner 2018/01/25 11:09:45 I see your point. Just a bit hesitant to make it t
kzar 2018/01/25 11:46:25 Well it was unfortunate about the "suppress_first_
Thomas Greiner 2018/01/25 13:09:03 Done.
210 210
211 /** 211 /**
212 * @namespace 212 * @namespace
213 * @static 213 * @static
214 */ 214 */
215 let Prefs = exports.Prefs = { 215 let Prefs = exports.Prefs = {
216 /** 216 /**
217 * Adds a callback that is called when the 217 * Adds a callback that is called when the
218 * value of a specified preference changed. 218 * value of a specified preference changed.
219 * 219 *
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 eventEmitter.emit(pref); 380 eventEmitter.emit(pref);
381 } 381 }
382 } 382 }
383 }); 383 });
384 } 384 }
385 385
386 Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded); 386 Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded);
387 } 387 }
388 388
389 init(); 389 init();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld