dependencies - Issue 29664623: Issue 6403 - Updated adblockplusui dependency

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29664623: Issue 6403 - Updated adblockplusui dependency (Closed)

Left Patch Set: Updated dependency to include translations Created Feb. 22, 2018, 5:18 p.m.

Right Patch Set: Created Feb. 23, 2018, 11:51 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:d9e8c5035624 git:0c8a9db	3 buildtools = buildtools hg:d9e8c5035624 git:0c8a9db

4 adblockpluscore = adblockpluscore hg:000df4267bc8 git:563b247	4 adblockpluscore = adblockpluscore hg:000df4267bc8 git:563b247

5 adblockplusui = adblockplusui hg:2a04df826943 git:04b38a9	5 adblockplusui = adblockplusui hg:08bd84805764 git:93b2850
kzar 2018/02/23 10:17:46 There have been more changes since, including upda There have been more changes since, including updated translations. Shouldn't we update to the latest revision (08bd84805764) instead? Thomas Greiner 2018/02/23 11:57:14 Done. Don't know why this part of the change wasn' Show quoted text On 2018/02/23 10:17:46, kzar wrote: > There have been more changes since, including updated translations. Shouldn't we > update to the latest revision (08bd84805764) instead? Done. Don't know why this part of the change wasn't included in the last patch together with the other ones. Glad you spotted that.
LEFT	RIGHT