Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/subscriptionInit.js

Issue 29664623: Issue 6403 - Updated adblockplusui dependency (Closed)
Patch Set: Created Feb. 23, 2018, 11:51 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/prefs.js ('k') | metadata.chrome » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/subscriptionInit.js
===================================================================
--- a/lib/subscriptionInit.js
+++ b/lib/subscriptionInit.js
@@ -23,10 +23,12 @@
SpecialSubscription} = require("subscriptionClasses");
const {FilterStorage} = require("filterStorage");
const {FilterNotifier} = require("filterNotifier");
+const info = require("info");
const {Prefs} = require("prefs");
const {Synchronizer} = require("synchronizer");
const {Utils} = require("utils");
const {initNotifications} = require("notificationHelper");
+const {updatesVersion} = require("../adblockplusui/lib/prefs");
let firstRun;
let subscriptionsCallback = null;
@@ -48,7 +50,7 @@
if (firstRun && (!FilterStorage.firstRun || Prefs.currentVersion))
exports.reinitialized = true;
- Prefs.currentVersion = require("info").addonVersion;
+ Prefs.currentVersion = info.addonVersion;
}
/**
@@ -204,8 +206,30 @@
Synchronizer.execute(subscription);
}
- if (firstRun && !Prefs.suppress_first_run_page)
- browser.tabs.create({url: browser.extension.getURL("firstRun.html")});
+ if (!Prefs.suppress_first_run_page)
+ {
+ let page = null;
+ if (firstRun)
+ {
+ page = "firstRun.html";
+ }
+ // For now we're limiting the updates page to users of
+ // Chromium-based browsers to gage its impact
+ else if (info.platform == "chromium" &&
+ updatesVersion > Prefs.last_updates_page_displayed)
+ {
+ page = "updates.html";
+ }
+
+ if (page)
+ {
+ browser.tabs.create({url: browser.extension.getURL(page)});
+
+ // For new users and users that have already seen this updates page we
+ // want to avoid showing it again for subsequent updates.
+ Prefs.last_updates_page_displayed = updatesVersion;
+ }
+ }
initNotifications();
}
« no previous file with comments | « lib/prefs.js ('k') | metadata.chrome » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld