Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29669624: Issue 6235 - Reinstall button on uninstallation page is below the fold (Closed)

Created:
Jan. 15, 2018, 4:47 p.m. by ire
Modified:
Jan. 17, 2018, 7:29 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 6235 - Reinstall button on uninstallation page is below the fold

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pages/uninstalled.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
ire
Jan. 15, 2018, 4:47 p.m. (2018-01-15 16:47:19 UTC) #1
ire
Ready for review
Jan. 15, 2018, 4:47 p.m. (2018-01-15 16:47:58 UTC) #2
juliandoucette
- Now it's inconsistent across pages (unintsalled-submit) - These colors clash - I think we ...
Jan. 15, 2018, 5:23 p.m. (2018-01-15 17:23:13 UTC) #3
ire
On 2018/01/15 17:23:13, juliandoucette wrote: > - Now it's inconsistent across pages (unintsalled-submit) > - ...
Jan. 15, 2018, 6:02 p.m. (2018-01-15 18:02:31 UTC) #4
ire
On 2018/01/15 18:02:31, ire wrote: > On 2018/01/15 17:23:13, juliandoucette wrote: > > - Now ...
Jan. 16, 2018, 8:40 a.m. (2018-01-16 08:40:02 UTC) #5
juliandoucette
Jan. 16, 2018, 8:08 p.m. (2018-01-16 20:08:50 UTC) #6
On 2018/01/16 08:40:02, ire wrote:
> Jeen's response: https://issues.adblockplus.org/ticket/6235#comment:7

:/

Ok, LGTM

Powered by Google App Engine
This is Rietveld