Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29669627: Issue 6175 - Animations are not displayed on faq pages (Closed)

Created:
Jan. 15, 2018, 5:57 p.m. by ire
Modified:
Jan. 16, 2018, 7:33 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 6175 - Animations are not displayed on faq pages

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M static/css/main.css View 1 chunk +6 lines, -0 lines 0 comments Download
M static/js/animation.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
ire
Jan. 15, 2018, 5:57 p.m. (2018-01-15 17:57:20 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29669627/diff/29669628/static/js/animation.js File static/js/animation.js (right): https://codereview.adblockplus.org/29669627/diff/29669628/static/js/animation.js#newcode92 static/js/animation.js:92: animation._data = request.responseXML.documentElement.getElementsByTagName("animation")[0]; (One of) the ...
Jan. 15, 2018, 5:59 p.m. (2018-01-15 17:59:10 UTC) #2
juliandoucette
Jan. 15, 2018, 11:45 p.m. (2018-01-15 23:45:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld