Issue 6264 - Can't prepare libadblockplus dependencies

third_party/libadblockplus_android/BUILD.gn

 import("//build/config/android/rules.gni")
 
 # Copy libadblockplus headers
 copy("copy_libadblockplus_include") {
   sources = [ "//third_party/libadblockplus/include" ]
   outputs = [ "${target_out_dir}/libadblockplus-binaries/include" ]
 }
 
 if (target_cpu == "arm") {
   _abi_directory = "armeabi-v7a"
@@ skipping 47 matching lines @@
 _cwd = rebase_path(".")
 _build_dir = "${target_out_dir}/build"
 _abs_build_dir = rebase_path("${_build_dir}")
 _abs_libadblockplus_dir = rebase_path("//third_party/libadblockplus")
 _abs_sdk_dir = rebase_path("//third_party/android_tools/sdk")
 
 _libadblockplus_binaries_dir = "${target_out_dir}/libadblockplus-binaries"
 _abs_libadblockplus_binaries_dir = rebase_path("${_libadblockplus_binaries_dir}")
 
 action("clear") {
-  script = "clear.py"
+  script = "clear_cache.py"

[anton, 2018/01/16 05:35:38]

"clear.py" is renamed to "clear_cache" just to remove misunderstanding as
now there is another "clear" in libadblockplus (the last one clears deps and
this one clear build cache).

[shoniko, 2018/01/16 07:14:14]

Acknowledged.

   args = [
     "${_cwd}/libadblockplus-android/.externalNativeBuild"
   ]
   outputs = [
     "${_build_dir}/tmp"
   ]
 }
 
 # Build libadblockplus-android using Gradle
 action("make") {
@@ skipping 45 matching lines @@
 # (see `_scanned_files = read_file(_info_path, "scope")` and it means _info_path file should already exist).
 # Since we do generate .aar from sources we can't have .aar existing when running 'gn ...'.
 # So the trick here is to prebuild libadblockplus-android with default V8 to generate .aar
 # right when running 'gn ...' and generate according .info file for it.
 
 # Obviously it slows down running 'gn ...' dramatically, but it allows to run 'gn' and 'ninja' only once.
 # Otherwise you have to run 'gn' and 'ninja' to generate .aar first, then rerun 'gn' with 'update_android_aar_prebuilts=true'
 # to generate .info and then rerun 'ninja' again to build with existing .info file.
 
 #print("Prebuilding libadblockplus-android to ${_abs_prebuild_dir}")
-exec_script("clear.py", [
+exec_script("clear_cache.py", [
   "${_cwd}/libadblockplus-android/.externalNativeBuild"
   ])
 exec_script("subproc.py", [
   "${_cwd}/gradlew",  "clean", "assembleAbi_${target_cpu}Release", ":libadblockplus-android-settings:assembleRelease",
 
   # cwd
   "--cwd${_cwd}",
 
   # environment variables
   "--envANDROID_HOME=${_abs_sdk_dir}",
@@ skipping 36 matching lines @@
 _settings_aar_path = rebase_path("${_build_dir}/libadblockplus-android-settings/outputs/aar/libadblockplus-android-settings-release.aar")
 android_aar_prebuilt("settings_aar_java") {
   unpack_deps = [
     ":make"
   ]
   aar_path = "$_settings_aar_path"
   info_path = "$_settings_info_path"
   proguard_configs = [ "proguard-adblock.txt" ]
   ignore_native_libraries = false
 }