third_party/libadblockplus_android/clear_cache.py - Issue 29670555: Issue 6264 - Can't prepare libadblockplus dependencies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: third_party/libadblockplus_android/clear_cache.py

Issue 29670555: Issue 6264 - Can't prepare libadblockplus dependencies (Closed)

Patch Set: Formatted with respect to eyeo python code style and tested with flake8 Created Jan. 16, 2018, 8:37 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 import os
	sergei 2018/01/16 17:29:08 Currently it looks like platform independent `rm - Currently it looks like platform independent `rm -rf {}`, should it be renamed? anton 2018/01/17 06:00:07 Acknowledged. Show quoted text On 2018/01/16 17:29:08, sergei wrote: > Currently it looks like platform independent `rm -rf {}`, should it be renamed? Acknowledged.
	2 import sys

	3 import shutil

	4

	5

	6 def main(argv):

	7 directory = argv[0]

	8 if os.path.exists(directory):

	9 shutil.rmtree(directory)

	10

	11 return 0

	12

	13

	14 if '__main__' == __name__:

	15 try:

	16 sys.exit(main(sys.argv[1:]))
	sergei 2018/01/16 17:29:08 What if remove sys.exit and `return 0` from `main` What if remove sys.exit and `return 0` from `main`? anton 2018/01/17 06:00:07 I've tried to keep Chromium code style and it's us Show quoted text On 2018/01/16 17:29:08, sergei wrote: > What if remove sys.exit and `return 0` from `main`? I've tried to keep Chromium code style and it's usually done like that (see `src/build/landmines.py`, `src/third_party/depot_tools/update_depot_tools_toggle.py`, etc).
	17 except KeyboardInterrupt:

	18 sys.stderr.write('interrupted\n')

	19 sys.exit(1)

OLD	NEW