Issue 6264 - Can't prepare libadblockplus dependencies

DEPS

 # This file is used to manage the dependencies of the Chromium src repo. It is
 # used by gclient to determine what version of each dependency to check out, and
 # where.
 #
 # For more information, please refer to the official documentation:
 #   https://sites.google.com/a/chromium.org/dev/developers/how-tos/get-the-code
 #
 # When adding a new dependency, please update the top-level .gitignore file
 # to list the dependency's destination directory.
 #
@@ skipping 1219 matching lines @@
       ],
     },
 
     {
       # Clear dependencies for libadblockplus (otherwise ensure_dependencies will fail to check deps revisions)
       'name': 'libadblockplus_clear_dependencies',
       'pattern': 'dependencies',
       'condition': 'checkout_android',
       'action': [
           'python',
-          'src/third_party/libadblockplus/clear_dependencies.py'

[sergei, 2018/01/17 09:49:03]

Why not to call here
python delete_dir.py src/third_party/libadblockplus/third_party/v8?

[anton, 2018/01/17 11:05:49]

Because `delete_dir.py` relates to 'libadblockplus-android' (and clears native
build cache) and `clear_dependencies.py` relates to 'libadblockplus'. They
should be separated 1)  logically 2) `delete_dir.py` is called 2 times (build
with built-in v8 to generate .info) and then before build with Chromium's v8.

+          'src/third_party/libadblockplus/delete_dir.py',
+          'src/third_party/libadblockplus/third_party/v8'
       ],
     },
 
     {
       # Download dependencies for libadblockplus.
       'name': 'libadblockplus_ensure_dependencies',
       'pattern': 'dependencies',
       'condition': 'checkout_android',
       'action': [
           'python',
@@ skipping 57 matching lines @@
 }
 
 recursedeps = [
   # buildtools provides clang_format, libc++, and libc++abi
   'src/buildtools',
   # android_tools manages the NDK.
   'src/third_party/android_tools',
   # ANGLE manages DEPS that it also owns the build files for, such as dEQP.
   ("src/third_party/angle", "DEPS.chromium"),
 ]