Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29670611: Issue 5844 - Remove redundant parentheses in sitescripts and abpsembly (Closed)

Created:
Jan. 16, 2018, 5:28 p.m. by rosie
Modified:
Jan. 26, 2018, 2:44 a.m.
CC:
tlucas
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

Remove redundant parentheses flagged by the new flake8 rule. I tested each modification against the original using pydiff, and the resulting bytecode is identical.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed the comments in /sitescripts #

Patch Set 3 : Fixed one more case of redundant parentheses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -51 lines) Patch
M sitescripts/crashes/web/submitCrash.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/extensions/utils.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/formmail/web/formmail2.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/notifications/parser.py View 1 chunk +8 lines, -8 lines 0 comments Download
M sitescripts/reports/bin/mailDigests.py View 2 chunks +2 lines, -2 lines 0 comments Download
M sitescripts/reports/bin/parseNewReports.py View 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/subscriptions/bin/generateReport.py View 2 chunks +2 lines, -2 lines 0 comments Download
M sitescripts/subscriptions/bin/updateStatusPage.py View 2 chunks +4 lines, -4 lines 0 comments Download
M sitescripts/subscriptions/knownIssuesParser.py View 3 chunks +4 lines, -4 lines 0 comments Download
M sitescripts/subscriptions/subscriptionParser.py View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M sitescripts/subscriptions/web/fallback.py View 2 chunks +2 lines, -2 lines 0 comments Download
M sitescripts/templateFilters.py View 1 1 chunk +14 lines, -12 lines 0 comments Download
M sitescripts/urlfixer/web/submitData.py View 1 chunk +2 lines, -2 lines 0 comments Download
M sitescripts/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
rosie
Jan. 16, 2018, 5:28 p.m. (2018-01-16 17:28:22 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py#newcode155 sitescripts/subscriptions/subscriptionParser.py:155: name, url = (self.name, value) I wonder whether we ...
Jan. 17, 2018, 1:43 a.m. (2018-01-17 01:43:52 UTC) #2
Vasily Kuznetsov
Hi Rosie! In general everything looks good. I just have a couple of comments on ...
Jan. 18, 2018, 10:46 a.m. (2018-01-18 10:46:07 UTC) #3
rosie
Hi Vasily and Sebastian! I made the two changes that were suggested. Hope everything else ...
Jan. 25, 2018, 4:13 p.m. (2018-01-25 16:13:48 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py#newcode155 sitescripts/subscriptions/subscriptionParser.py:155: name, url = (self.name, value) On 2018/01/25 16:13:48, rosie ...
Jan. 25, 2018, 6:15 p.m. (2018-01-25 18:15:01 UTC) #5
rosie
https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29670611/diff/29670612/sitescripts/subscriptions/subscriptionParser.py#newcode155 sitescripts/subscriptions/subscriptionParser.py:155: name, url = (self.name, value) On 2018/01/25 18:15:00, Sebastian ...
Jan. 25, 2018, 7:03 p.m. (2018-01-25 19:03:40 UTC) #6
Sebastian Noack
LGTM. Can you please close the review for apbsembly, and update the title of this ...
Jan. 25, 2018, 7:24 p.m. (2018-01-25 19:24:00 UTC) #7
rosie
On 2018/01/25 19:24:00, Sebastian Noack wrote: > LGTM. Can you please close the review for ...
Jan. 25, 2018, 7:30 p.m. (2018-01-25 19:30:44 UTC) #8
Vasily Kuznetsov
Jan. 25, 2018, 7:40 p.m. (2018-01-25 19:40:48 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld