Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/reports/bin/mailDigests.py

Issue 29670611: Issue 5844 - Remove redundant parentheses in sitescripts and abpsembly (Closed) Base URL: https://hg.adblockplus.org/sitescripts/
Patch Set: Addressed the comments in /sitescripts Created Jan. 25, 2018, 4:12 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sitescripts/notifications/parser.py ('k') | sitescripts/reports/bin/parseNewReports.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/reports/bin/mailDigests.py
===================================================================
--- a/sitescripts/reports/bin/mailDigests.py
+++ b/sitescripts/reports/bin/mailDigests.py
@@ -111,7 +111,7 @@
groups[report['site']] = {'name': report['site'], 'reports': [report], 'weight': report['weight'], 'dumpAll': False}
miscGroup = {'name': 'Misc', 'reports': [], 'weight': None, 'dumpAll': True}
- for (site, group) in groups.items():
+ for site, group in groups.items():
if len(group['reports']) == 1:
miscGroup['reports'].append(group['reports'][0])
del groups[site]
@@ -173,7 +173,7 @@
raise Exception('No interval specified')
interval = sys.argv[1]
- if not (interval in ['all', 'week', 'day']):
+ if interval not in ['all', 'week', 'day']:
raise Exception('Invalid interval')
if interval == 'week' and len(sys.argv) < 3:
« no previous file with comments | « sitescripts/notifications/parser.py ('k') | sitescripts/reports/bin/parseNewReports.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld