sitescripts/subscriptions/knownIssuesParser.py - Issue 29670611: Issue 5844 - Remove redundant parentheses in sitescripts and abpsembly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/subscriptions/knownIssuesParser.py

Issue 29670611: Issue 5844 - Remove redundant parentheses in sitescripts and abpsembly (Closed) Base URL: https://hg.adblockplus.org/sitescripts/

Patch Set: Addressed the comments in /sitescripts Created Jan. 25, 2018, 4:12 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/subscriptions/knownIssuesParser.py

===================================================================

--- a/sitescripts/subscriptions/knownIssuesParser.py

+++ b/sitescripts/subscriptions/knownIssuesParser.py

@@ -186,7 +186,7 @@

if line.find('=') < 0:

print >>sys.stderr, 'Unrecognized line %s' % line

continue

- (key, value) = line.split('=', 1)

+ key, value = line.split('=', 1)

key = key.rstrip()

value = value.lstrip()

if key == 'url':

@@ -199,7 +199,7 @@

def findMatches(it, lang):

global supportedKeys

- (rules, rulesets) = getRules()

+ rules, rulesets = getRules()

for line in it:

match = re.search(r'<([\w\-]+)\s*(.*?)\s*/?>([^<>]*)', line)

@@ -216,9 +216,9 @@

for key, t in supportedKeys.iteritems():

if len(t) == 3:

- (requiredTag, requiredAttrs, requiredValue) = t

+ requiredTag, requiredAttrs, requiredValue = t

else:

- (requiredTag, requiredAttrs) = t

+ requiredTag, requiredAttrs = t

requiredValue = None

requiredAttrs = requiredAttrs.split(' ')

if requiredTag != tag: