Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 29670669: Issue 268 - Removed cssfxjs dependency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by juliandoucette
Modified:
1 year, 9 months ago
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 268 - Removed cssfxjs dependency

Patch Set 1 #

Patch Set 2 : Addressed #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M includes/index.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/polyfills.tmpl View 1 chunk +0 lines, -6 lines 0 comments Download
M includes/styles.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/contribute.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pages/features.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
R static/css/empty.css View 0 chunks +-1 lines, --1 lines 0 comments Download
R static/js/vendor/cssfx.min.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
juliandoucette
1 year, 9 months ago (2018-01-16 23:33:20 UTC) #1
juliandoucette
I chose to remove this dependency instead of deferring it like the ticket requested because ...
1 year, 9 months ago (2018-01-16 23:35:59 UTC) #2
ire
On 2018/01/16 23:35:59, juliandoucette wrote: > I chose to remove this dependency instead of deferring ...
1 year, 9 months ago (2018-01-17 07:38:40 UTC) #3
juliandoucette
New PatchSet uploaded. > Ack. Could you please update the ticket to reflect this? Done. ...
1 year, 9 months ago (2018-01-17 14:58:55 UTC) #4
ire
LGTM On 2018/01/17 14:58:55, juliandoucette wrote: > New PatchSet uploaded. > > > Ack. Could ...
1 year, 9 months ago (2018-01-18 10:27:56 UTC) #5
juliandoucette
On 2018/01/18 10:27:56, ire wrote: > NIT: The title still refers to deferring cssfx instead ...
1 year, 9 months ago (2018-01-18 16:49:02 UTC) #6
juliandoucette
1 year, 9 months ago (2018-01-18 21:38:23 UTC) #7

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5