Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(407)

Issue 29671561: Issue 6274 - ANR on cancelling elemhide thread for load error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by anton
Modified:
2 years, 1 month ago
Visibility:
Public.

Description

Issue 6274 - ANR on cancelling elemhide thread for load error

Patch Set 1 #

Total comments: 2

Patch Set 2 : reversed logics (Jens comment) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java View 1 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5
anton
2 years, 1 month ago (2018-01-17 07:13:04 UTC) #1
jens
https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java File libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java (right): https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java#newcode1078 libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java:1078: if (!isFinished.get()) To make the if statement more readable, ...
2 years, 1 month ago (2018-01-17 08:28:43 UTC) #2
anton
https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java File libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java (right): https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java#newcode1078 libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java:1078: if (!isFinished.get()) On 2018/01/17 08:28:43, jens wrote: > To ...
2 years, 1 month ago (2018-01-17 08:33:55 UTC) #3
jens
On 2018/01/17 08:33:55, anton wrote: > https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java > File > libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java > (right): > > ...
2 years, 1 month ago (2018-01-17 08:42:45 UTC) #4
diegocarloslima
2 years, 1 month ago (2018-01-17 11:55:28 UTC) #5
On 2018/01/17 08:42:45, jens wrote:
> On 2018/01/17 08:33:55, anton wrote:
> >
>
https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-andr...
> > File
> >
>
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29671561/diff/29671562/libadblockplus-andr...
> >
>
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java:1078:
> > if (!isFinished.get())
> > On 2018/01/17 08:28:43, jens wrote:
> > > To make the if statement more readable, I would probably reverse the
logic.
> > 
> > Done. See patch set #2
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5