Issue 6066 - Implement 'force update' functionality for subscriptions

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.sbrowser.contentblocker;
 
 import org.adblockplus.sbrowser.contentblocker.engine.Engine;
 import org.adblockplus.sbrowser.contentblocker.engine.EngineService;
 import org.adblockplus.adblockplussbrowser.R;
+import org.adblockplus.sbrowser.contentblocker.util.ConnectivityUtils;
 import org.adblockplus.sbrowser.contentblocker.util.SharedPrefsUtils;
 
 import android.app.AlertDialog;
+import android.app.Fragment;
 import android.app.ProgressDialog;
 import android.content.DialogInterface;
 import android.content.DialogInterface.OnClickListener;
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Bundle;
+import android.preference.Preference;
 import android.preference.PreferenceActivity;
 import android.preference.PreferenceManager;
 import android.text.Html;
 import android.util.Log;
 import android.view.Gravity;
 import android.widget.Button;
 import android.widget.LinearLayout;
 
 public class MainPreferences extends PreferenceActivity implements
     EngineService.OnEngineCreatedCallback, SharedPrefsUtils.OnSharedPreferenceChangeListener,
-    Engine.SubscriptionUpdateCallback
+    Engine.SubscriptionUpdateCallback, Preference.OnPreferenceClickListener
 {
   private static final String TAG = MainPreferences.class.getSimpleName();
   private Engine engine = null;
   private AlertDialog dialog;
   private int dialogTitleResId;
 
   @Override
   public void onCreate(Bundle savedInstanceState)
   {
     super.onCreate(savedInstanceState);
     PreferenceManager.setDefaultValues(this, R.xml.preferences_main, false);
 
     this.getFragmentManager()
         .beginTransaction()
-        .replace(android.R.id.content, new Preferences())
+        .replace(android.R.id.content, new Preferences(), Preferences.class.getSimpleName())
         .commit();
   }
 
   @Override
   protected void onStart()
   {
     this.dialogTitleResId = R.string.initialization_title;
     this.dialog = ProgressDialog.show(this,
         this.getString(this.dialogTitleResId),
         this.getString(R.string.initialization_message));
@@ skipping 124 matching lines @@
     {
       this.engine.setSubscriptionUpdateCallback(this);
     }
 
     if (this.dialogTitleResId == R.string.initialization_title)
     {
       this.dismissDialog();
 
       this.checkForCompatibleSBrowserAndProceed();
     }
+
+    Fragment preferecesFragment = getFragmentManager().findFragmentByTag(Preferences.class.getSimpleName());
+    Preference button = ((Preferences) preferecesFragment).findPreference(getString(R.string.key_update_subscriptions));
+    button.setOnPreferenceClickListener(this);
   }
 
   @Override
   public void onSharedPreferenceChanged(String key)
   {
     if (this.getString(R.string.key_automatic_updates).equals(key) && this.engine != null)
     {
       this.engine.connectivityChanged();
     }
     else if (this.getString(R.string.key_acceptable_ads).equals(key))
@@ skipping 18 matching lines @@
     this.dialog = ProgressDialog.show(this, null, enabled
         ? getString(R.string.add_subscription_dialog_message)
         : getString(R.string.remove_subscription_dialog_message));
   }
 
   @Override
   public void subscriptionUpdatedApplied()
   {
     this.dismissDialog();
   }
+
+  @Override
+  public boolean onPreferenceClick(Preference preference)

[diegocarloslima, 2018/01/19 13:59:00]

So far, instead of adding specific preference logic here, we extend a preference
class and add the specific behavior on each custom preference class. This helps
to avoid largely increasing the size of this file with per-preference logic

[jens, 2018/01/19 14:32:55]

Right, but we only did that for those preferences, that open a new screen. For
toggling AA and the automatic update rules, we used MainPreferences. The force
update also not opens a new screen but only shows a dialog (like automatic
updates). Because of that I would prefer to implement the listener and keep the
logic in MainPreferences for now.

+  {
+    if (getString(R.string.key_update_subscriptions).equals(preference.getKey()))
+    {
+      boolean hasInternet = ConnectivityUtils.hasInternetConnection(this);
+      if (hasInternet && ConnectivityUtils.hasWifiConnection(this))
+      {
+        engine.forceUpdateSubscriptions(false);
+      }
+      else
+      {
+        this.dialog = new AlertDialog.Builder(this)
+            .setTitle(R.string.update_subscriptions)
+            .setMessage(
+                hasInternet
+                ? R.string.metered_connection_warning
+                : R.string.check_your_connection)
+            .setNegativeButton(android.R.string.cancel, new OnClickListener()
+            {
+              @Override
+              public void onClick(DialogInterface dialog, int which)
+              {
+                dialog.cancel();
+              }
+            })
+            .create();
+
+        if (hasInternet)
+        {
+          this.dialog.setButton(DialogInterface.BUTTON_POSITIVE, getString(android.R.string.yes),
+              new OnClickListener()
+              {
+                @Override
+                public void onClick(DialogInterface dialogInterface, int i)
+                {
+                  engine.forceUpdateSubscriptions(true);
+                }
+              });
+        }
+        this.dialog.show();
+      }
+      return true;
+    }
+    return false;
+  }
 }