Issue 6066 - Implement 'force update' functionality for subscriptions

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 186 matching lines @@
     }
 
     if (this.dialogTitleResId == R.string.initialization_title)
     {
       this.dismissDialog();
 
       this.checkForCompatibleSBrowserAndProceed();
     }
 
     Fragment preferecesFragment = getFragmentManager().findFragmentByTag(Preferences.class.getSimpleName());
-    Preference button = ((Preferences) preferecesFragment).findPreference(getString(R.string.key_update_subscriptions));
+    Preference button = ((Preferences) preferecesFragment).findPreference(getString(R.string.key_force_update_subscriptions));
     button.setOnPreferenceClickListener(this);
   }
 
   @Override
   public void onSharedPreferenceChanged(String key)
   {
     if (this.getString(R.string.key_automatic_updates).equals(key) && this.engine != null)
     {
       this.engine.connectivityChanged();
     }
@@ skipping 21 matching lines @@
         : getString(R.string.remove_subscription_dialog_message));
   }
 
   @Override
   public void subscriptionUpdatedApplied()
   {
     this.dismissDialog();
   }
 
   @Override
   public boolean onPreferenceClick(Preference preference)

[diegocarloslima, 2018/01/19 13:59:00]

So far, instead of adding specific preference logic here, we extend a preference
class and add the specific behavior on each custom preference class. This helps
to avoid largely increasing the size of this file with per-preference logic

[jens, 2018/01/19 14:32:55]

Right, but we only did that for those preferences, that open a new screen. For
toggling AA and the automatic update rules, we used MainPreferences. The force
update also not opens a new screen but only shows a dialog (like automatic
updates). Because of that I would prefer to implement the listener and keep the
logic in MainPreferences for now.

   {
-    if (getString(R.string.key_update_subscriptions).equals(preference.getKey()))
-    {
-      boolean hasInternet = ConnectivityUtils.hasInternetConnection(this);
-      if (hasInternet && ConnectivityUtils.hasWifiConnection(this))
+    if (getString(R.string.key_force_update_subscriptions).equals(preference.getKey()))
+    {
+      if (ConnectivityUtils.hasNonMeteredConnection(this))
       {
         engine.forceUpdateSubscriptions(false);
       }
       else
       {
+        boolean meteredInternetAvailable = ConnectivityUtils.canUseInternet(this, true);
         this.dialog = new AlertDialog.Builder(this)
             .setTitle(R.string.update_subscriptions)
             .setMessage(
-                hasInternet
+                meteredInternetAvailable
                 ? R.string.metered_connection_warning
                 : R.string.check_your_connection)
             .setNegativeButton(android.R.string.cancel, new OnClickListener()
             {
               @Override
               public void onClick(DialogInterface dialog, int which)
               {
                 dialog.cancel();
               }
             })
             .create();
 
-        if (hasInternet)
+        if (meteredInternetAvailable)
         {
           this.dialog.setButton(DialogInterface.BUTTON_POSITIVE, getString(android.R.string.yes),
               new OnClickListener()
               {
                 @Override
                 public void onClick(DialogInterface dialogInterface, int i)
                 {
                   engine.forceUpdateSubscriptions(true);
                 }
               });
         }
         this.dialog.show();
       }
       return true;
     }
     return false;
   }
 }