Make new options page compatible with edge

skin/desktop-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 207 matching lines @@
 .side-controls:not(.wrap)
 {
   margin: 0.8rem 0rem;
   display: flex;
   justify-content: flex-end;
 }
 
 .side-controls button
 {
   margin: 0rem;
-  -moz-margin-start: 1rem;
-  -webkit-margin-start: 1rem;
+}
+
+/*
+  Due to Edge adoption as new target browser
+  we cannot use -moz/webkit-margin-start
+  or -moz/webkit-margin-end because
+  these lack Edge support.
+  Yet we need to preserve html direction
+  and potential UI that might swap right to left.
+*/
+html:not([dir="rtl"]) .side-controls button
+{
+  margin-left: 1rem;
+}
+
+html[dir="rtl"] .side-controls button
+{
+  margin-right: 1rem;
 }
 
 .side-controls.wrap button
 {
   margin: 0.6rem 0rem;
-  -moz-margin-start: auto;
-  -webkit-margin-start: auto;
+}
+
+html:not([dir="rtl"]) .side-controls.wrap buttonn

[Thomas Greiner, 2018/01/22 13:06:38]

Typo: Replace "buttonn" with "button"

+{
+  margin-left: auto;
+}
+
+html[dir="rtl"] .side-controls.wrap button
+{
+  margin-right: auto;
 }
 
 /*
   icons
  */
 
 .icon
 {
   border: 0px;
   padding: 0px;
@@ skipping 290 matching lines @@
 
 #sidebar,
 #sidebar .fixed,
 [role="tablist"]
 {
   width: 14.3rem;
 }
 
 #sidebar
 {
   flex-shrink: 0; 

[Thomas Greiner, 2018/01/22 13:06:38]

Detail: Interesting that you added some trailing whitespace here because I
assumed your setup prevents you from doing so.

 }
 
 #sidebar .fixed
 {
   top: 1.2rem;
   bottom: 0rem;
   height: auto;
 }
 
 #sidebar header
@@ skipping 50 matching lines @@
   padding: 0rem;
   position: relative;
   font-size: 1rem;
 }
 
 [role="tablist"] li a
 {
   display: flex;
   margin-top: -1px;
   padding: 1rem 0.8rem;
-  -moz-margin-end: -1px;
-  -webkit-margin-end: -1px;
-  -moz-margin-start: -1px;
-  -webkit-margin-start: -1px;
+  margin-left: -1px;
+  margin-right: -1px;
   border-color: #CDCDCD transparent;
   border-style: solid;
   border-width: 1px;
   text-decoration: none;
   color: inherit;
   cursor: pointer;
 }
 
 li a[role="tab"][aria-selected]
 {
-  -moz-border-start-color: #CDCDCD;
-  -webkit-border-start-color: #CDCDCD;
   font-weight: 700;
   background-color: #FFF;
 }
 
+html:not([dir="rtl"]) li a[role="tab"][aria-selected]
+{
+  border-left-color: #CDCDCD;
+}
+
+html[dir="rtl"] li a[role="tab"][aria-selected]
+{
+  border-right-color: #CDCDCD;
+}
+
 #sidebar footer
 {
   width: 100%;
 }
 
 #sidebar footer p
 {
   display: flex;
   justify-content: center;
   margin: 1rem 0rem;
 }
 
 /* This is a stopgap solution of footer overlapping tabs on low resolutions */
 @media (min-height: 37rem)
 {
   #sidebar .fixed
-  {
+{
     position: fixed;
   }
 
   #sidebar footer
-  {
+{
     bottom: 0px;
     position: absolute;
   }
+

[Thomas Greiner, 2018/01/22 13:06:38]

Detail: I assume those three changes were made by your linter setup so I'd
suggest checking your configuration for issues.

 }
 
 /*
   Main content
  */
 
 body[data-tab|="general"] #content-general,
 body[data-tab|="advanced"] #content-advanced,
 body[data-tab|="whitelist"] #content-whitelist,
 body[data-tab|="help"] #content-help
@@ skipping 55 matching lines @@
 }
 
 section.cols
 {
   display: flex;
 }
 
 section.cols > *:first-child
 {
   flex: 1;
-  -moz-margin-end: 2rem;
-  -webkit-margin-end: 2rem;
+}
+
+html:not([dir="rtl"]) section.cols > *:first-child
+{
+  margin-right: 2rem;
+}
+
+html[dir="rtl"] section.cols > *:first-child
+{
+  margin-left: 2rem;
 }
 
 section.cols > *:last-child
 {
   flex: 3;
 }
 
 /*
   Acceptable ads
  */
@@ skipping 54 matching lines @@
 html[dir="rtl"] button
 {
   left: auto;
   right: 0rem;
 }
 
 #acceptable-ads label
 {
   font-weight: 700;
   font-size: 1rem;
-  -moz-margin-end: 0.5rem;
-  -webkit-margin-end: 0.5rem;
+}
+
+html:not([dir="rtl"]) #acceptable-ads label
+{
+  margin-right: 0.5rem;
+}
+
+html[dir="rtl"] #acceptable-ads label
+{
+  margin-left: 0.5rem;
 }
 
 #dnt
 {
   padding: 0.8rem;
   border: 1px solid #077CA6;
 }
 
 .new
 {
@@ skipping 143 matching lines @@
 .th .col5:nth-of-type(4),
 .table .col5:nth-of-type(4)
 {
   flex: 1;
 }
 
 .th .col5:nth-of-type(5),
 .table .col5:nth-of-type(5)
 {
   flex: 1;
-  -moz-margin-start: 0;
-  -webkit-margin-start: 0;
-  -moz-margin-end: 1.8rem;
-  -webkit-margin-end: 1.8rem;
+}
+
+html:not([dir="rtl"]) .th .col5:nth-of-type(5),
+html:not([dir="rtl"]) .table .col5:nth-of-type(5)
+{
+  margin-left: 0;
+  margin-right: 1.8rem;
+}
+
+html[dir="rtl"] .th .col5:nth-of-type(5),
+html[dir="rtl"] .table .col5:nth-of-type(5)
+{
+  margin-right: 0;
+  margin-left: 1.8rem;
 }
 
 .table.cols > span
 {
   margin: 0rem;
 }
 
 .table.cols li
 {
   padding: 0.5rem 0rem;
 }
 
-.table.cols .state
+html:not([dir="rtl"]) .table.cols .state
 {
-  -moz-margin-start: 1rem;
-  -webkit-margin-start: 1rem;
+  margin-left: 1rem;
+}
+
+html[dir="rtl"] .table.cols .state
+{
+  margin-right: 1rem;
 }
 
 .table.cols .gear
 {
   margin: 0rem 
 }
 
 #dialog .table.list li
 {
   display: block;
@@ skipping 36 matching lines @@
 }
 
 /*
   Tooltips
 */
 
 .tooltip
 {
   position: relative;
   margin: 0rem;
-  -moz-margin-end: 1rem;
-  -webkit-margin-end: 1rem;
   line-height: 1.5rem;
   text-decoration: none;
   cursor: help;
 }
 
+html:not([dir="rtl"]) .tooltip
+{
+  margin-right: 1rem;
+}
+
+html[dir="rtl"] .tooltip
+{
+  margin-left: 1rem;
+}
+
 /* 
   Used for translatable screen reader only content.
   e.g.: Use instead of aria-label to avoid complex attribute value translation
 */
 .sr-only
 {
   position: absolute;
   overflow: hidden;
   clip: rect(0, 0, 0, 0);
   width: 1px;
@@ skipping 31 matching lines @@
 
 #content-whitelist form input
 {
   flex: 1;
   height: 100%;
   padding: 0.5rem 1rem;
   font-size: 1rem;
   border: 2px solid #077CA6;
 }
 
-#content-whitelist form button
+html:not([dir="rtl"]) #content-whitelist form button
 {
-  -moz-margin-start: 0.7rem;
-  -webkit-margin-start: 0.7rem;
+  margin-left: 0.7rem;
+}
+
+html[dir="rtl"] #content-whitelist form button
+{
+  margin-right: 0.7rem;
 }
 
 #whitelisting-table li
 {
   padding-left: 1.4rem;
   padding-right: 1.4rem;
   border-left: 0rem;
   border-right: 0rem; 
 }
 
@@ skipping 212 matching lines @@
 
 #social ul
 {
   list-style: none;
   padding: 0px;
 }
 
 #social ul li
 {
   display: inline-block;
-  -moz-margin-end: 1rem;
-  -webkit-margin-end: 1rem;
+}
+
+html:not([dir="rtl"]) #social ul li
+{
+  margin-right: 1rem;
+}
+
+html[dir="rtl"] #social ul li
+{
+  margin-left: 1rem;
 }
 
 #social ul li a
 {
   display: block;
   text-align: center;
   text-decoration: none;
 }
 
 /*
@@ skipping 150 matching lines @@
   font-size: 1rem;
   color: #077CA6;
   background-color: #E1F2FA;
 }
 
 #notification strong
 {
   flex: 1;
   text-align: center;
 }