Make new options page compatible with edge

desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 515 matching lines @@
                                             type + "_title");
           }
 
           addSubscription(subscription);
         }
       });
   }
 
   function findParentData(element, dataName, returnElement)
   {
-    while (element)
-    {
-      if (element.hasAttribute("data-" + dataName))
-      {
-        if (returnElement)
-          return element;
-        return element.getAttribute("data-" + dataName);
-      }
-
-      element = element.parentElement;
-    }
-    return null;
+    element = element.closest(`[data-${dataName}]`);

[saroyanm, 2018/02/08 14:59:09]

Detail: We are usually careful when it comes to experimental technologies.

Make sense to find out which Edge versions are we supporting.
This feature is only supported in edge 15 and up.

Ollie, can you please let us know which versions of Edge are we supporting ?

Probably make sense to update that info in as well:
https://adblockplus.org/en/requirements

[a.giammarchi, 2018/02/08 15:07:21]

FWIW closest is not really experimental, it has been around for years, but in
our edge metadata we target 40.15063.0.0 which is >= 15 so I hope there's really
nothing to worry about.

[saroyanm, 2018/02/08 15:20:18]

According to MDN it is ->
https://developer.mozilla.org/en-US/docs/Web/API/Element/closest 
But might be their page needs an update.
Noted.
Anyway I've created a ticket ->
https://gitlab.com/eyeo/web.adblockplus.org/issues/17

[a.giammarchi, 2018/02/08 15:27:29]

don't trust everything you read in MDN ... it's updated by devs that very often
forget to update.

closest is in the living standard since years now, it's been polyfilled 3+ years
ago -> https://github.com/WebReflection/dom4 and IE15 was last one to implement
it.

It was a good catch/safety call but also both me and I guess Thomas too checked
before shipping it.

I'd like to share this little CLI that is configured with our target browsers
and tell instantly if we can support this or that. Let's follow up in irc.

[saroyanm, 2018/02/08 15:38:30]

Thanks for the links and info.
Acknowledged.

+    if (!element)
+      return null;
+    if (returnElement)
+      return element;
+    return element.getAttribute(`data-${dataName}`);
   }
 
   function sendMessageHandleErrors(message, onSuccess)
   {
     browser.runtime.sendMessage(message, (errors) =>
     {
       if (errors.length > 0)
         alert(errors.join("\n"));
       else if (onSuccess)
         onSuccess();
@@ skipping 353 matching lines @@
 
     // General tab
     getDocLink("contribute", (link) =>
     {
       E("contribute").href = link;
     });
     getDocLink("acceptable_ads_criteria", (link) =>
     {
       setLinks("enable-acceptable-ads-description", link);
     });
-    setElementText(E("tracking-warning-1"), "options_tracking_warning_1", 
+    setElementText(E("tracking-warning-1"), "options_tracking_warning_1",
       [getMessage("common_feature_privacy_title"),
-      getMessage("options_acceptableAds_ads_label")]);
-    setElementText(E("tracking-warning-3"), "options_tracking_warning_3", 
+       getMessage("options_acceptableAds_ads_label")]);
+    setElementText(E("tracking-warning-3"), "options_tracking_warning_3",
       [getMessage("options_acceptableAds_privacy_label")]);
 
     getDocLink("privacy_friendly_ads", (link) =>
     {
       E("enable-acceptable-ads-privacy-description").href = link;
     });
     getDocLink("adblock_plus_{browser}_dnt", url =>
     {
       setLinks("dnt", url);
     });
@@ skipping 145 matching lines @@
     {
       acceptableAds.setAttribute("aria-checked", true);
       acceptableAdsPrivacy.setAttribute("aria-disabled", false);
     }
     else if (acceptableAdsPrivacyUrl in subscriptionsMap)
     {
       acceptableAds.setAttribute("aria-checked", true);
       acceptableAdsPrivacy.setAttribute("aria-checked", true);
       acceptableAdsPrivacy.setAttribute("aria-disabled", false);
 
       if (navigator.doNotTrack != 1)

[saroyanm, 2018/02/08 14:59:09]

Edge uses window.doNotTrack:

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack#Browser...

         acceptableAdsForm.classList.add("show-dnt-notification");
     }
     else
     {
       // Using aria-disabled in order to keep the focus
       acceptableAdsPrivacy.setAttribute("aria-disabled", true);
       acceptableAdsPrivacy.setAttribute("tabindex", -1);
     }
   }
 
@@ skipping 187 matching lines @@
         setPrivacyConflict();
         break;
       case "downloading":
       case "downloadStatus":
       case "homepage":
       case "lastDownload":
       case "title":
         updateSubscription(subscription);
         break;
       case "added":
-        let {url, recommended} = subscription;
+        let {url} = subscription;
         // Handle custom subscription
         if (/^~user/.test(url))
         {
           loadCustomFilters(subscription.filters);
           return;
         }
         else if (url in subscriptionsMap)
           updateSubscription(subscription);
         else
           addSubscription(subscription);
@@ skipping 160 matching lines @@
   });
   browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }