pages/index.tmpl - Issue 29673627: Issue 4797 - Separate white box and text from eyeo.com homepage banner

Delta Between Two Patch Sets: pages/index.tmpl

Issue 29673627: Issue 4797 - Separate white box and text from eyeo.com homepage banner (Closed) Base URL: https://hg.adblockplus.org/web.eyeo.com

Left Patch Set: Created Jan. 18, 2018, 4:41 p.m.

Right Patch Set: Use header element for #hero Created Jan. 26, 2018, 10:10 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=About Us	1 title=About Us

2 description=Founded in 2011, eyeo is the company behind Adblock Plus, Adblock Br owser and Flattr. We build products that millions of people use everyday to impr ove their online experience.	2 description=Founded in 2011, eyeo is the company behind Adblock Plus, Adblock Br owser and Flattr. We build products that millions of people use everyday to impr ove their online experience.

3	3

4 <head>	4 <head>

5 <? include index/style ?>	5 <? include index/style ?>

6 <script type="application/ld+json">	6 <script type="application/ld+json">

7 {	7 {

8 "@context": "http://schema.org",	8 "@context": "http://schema.org",

9 "@type": "Organization",	9 "@type": "Organization",

10 "url": "{{ config.get("general", "siteurl") }}",	10 "url": "{{ config.get("general", "siteurl") }}",

11 "logo": "{{ config.get("general", "siteurl") }}/images/logo-3x.png"	11 "logo": "{{ config.get("general", "siteurl") }}/images/logo-3x.png"

12 }	12 }

13 </script>	13 </script>

14 </head>	14 </head>

15	15

16 <div id="home-image-container">	16 <header class="bg-accent" id="hero">

17 <div>	17 <div class="content-block">
juliandoucette 2018/01/18 21:43:51 NIT: This could be a header, heading, and subtitle NIT: This could be a header, heading, and subtitle <header> <img> <div> <h1> <p> ire 2018/01/19 09:16:27 I considered this but I didn't really think that t Show quoted text On 2018/01/18 21:43:51, juliandoucette wrote: > NIT: This could be a header, heading, and subtitle > > <header> > <img> > <div> > <h1> > <p> I considered this but I didn't really think that this was the page header. Seems more like a tagline or something rather than an <h1> juliandoucette 2018/01/22 16:06:01 Seems like a header and tagline to me. Why does it Show quoted text On 2018/01/19 09:16:27, ire wrote: > I considered this but I didn't really think that this was the page header. Seems > more like a tagline or something rather than an <h1> Seems like a header and tagline to me. Why does it not seem that way to you? ire 2018/01/25 11:54:14 To clarify, I said the text seems like a tagline r Show quoted text On 2018/01/22 16:06:01, juliandoucette wrote: > On 2018/01/19 09:16:27, ire wrote: > > I considered this but I didn't really think that this was the page header. > Seems > > more like a tagline or something rather than an <h1> > > Seems like a header and tagline to me. Why does it not seem that way to you? To clarify, I said the text seems like a tagline rather than a heading (i.e. <h1>..<h6>). I'm not necessarily arguing against the use of the <header> element. However, the use of the <header> element typically implies than an actual heading (i.e. <h1>..<h6>) will be within. My position is that I don't think the text "We want to make the internet better for everyone. Purging bad ads is a good start" is heading text. It seems to me to be a tagline, so a paragraph element that may go beneath an actual heading. I think the heading (<h1>) of this page should be "About Us" or something similar since it's the title of the document. Also, this is probably an unconscious opinion I've had, but I don't think headings (i.e. <h1>..<h6>) are generally sentences. But that might not be a real requirement. juliandoucette 2018/01/25 14:27:29 I understood you. I was arguing against your inter Show quoted text On 2018/01/25 11:54:14, ire wrote: > To clarify, I said the text seems like a tagline rather than a heading (i.e. > <h1>..<h6>). > > I'm not necessarily arguing against the use of the <header> element. However, > the use of the <header> element typically implies than an actual heading (i.e. > <h1>..<h6>) will be within. My position is that I don't think the text "We want > to make the internet better for everyone. Purging bad ads is a good start" is > heading text. It seems to me to be a tagline, so a paragraph element that may go > beneath an actual heading. > > I think the heading (<h1>) of this page should be "About Us" or something > similar since it's the title of the document. > > Also, this is probably an unconscious opinion I've had, but I don't think > headings (i.e. <h1>..<h6>) are generally sentences. But that might not be a real > requirement. I understood you. I was arguing against your interpretation of heading contents. Although it's not spelled out in the standard, heading contents (especially h1 > h2 > h3 ...) is one of the most important elements for search engine optimization. A "good" heading is typically made up of a short sentence containing as many keywords as possible without duplication or spam (AFAIK). Example: bbc.com - All of the article titles are h1s on their respective pages - All of the article titles are short (optimized?) sentences Of course, I will admit that "We want to make the internet better for everyone" is not very "optimized". And that I think it really does make a better "tagline" or "description" underneath a heading. But, perhaps, it is better than "About Us" (the unfortunate title of this page and many others on the internet - unfortunate because it's hard to compete over the keywords "about" and "us"). Therefore, I'm arguing that the proper implementation of this page consists of a header containing the <h1> "We want to make the internet better for everyone." and the subtitle <p> "Purging bad ads is a good start." - Acknowledging that we could make it all one h1 and <strong> the first part if we wanted to optimize our SEO slightly at the expense of our accessibility - Acknowledging that I would accept an sr-only h1 "eyeo" above the "tagline" that we are arguing about as a compromise between both of our solutions - But that would still not be a "good" solution IMO because it would be a wasted opportunity to put more searchable contents within the h1 on our homepage ire 2018/01/26 10:11:00 Okay. I'm going with making the whole phrase the < Show quoted text On 2018/01/25 14:27:29, juliandoucette wrote: > On 2018/01/25 11:54:14, ire wrote: > > To clarify, I said the text seems like a tagline rather than a heading (i.e. > > <h1>..<h6>). > > > > I'm not necessarily arguing against the use of the <header> element. However, > > the use of the <header> element typically implies than an actual heading (i.e. > > <h1>..<h6>) will be within. My position is that I don't think the text "We > want > > to make the internet better for everyone. Purging bad ads is a good start" is > > heading text. It seems to me to be a tagline, so a paragraph element that may > go > > beneath an actual heading. > > > > I think the heading (<h1>) of this page should be "About Us" or something > > similar since it's the title of the document. > > > > Also, this is probably an unconscious opinion I've had, but I don't think > > headings (i.e. <h1>..<h6>) are generally sentences. But that might not be a > real > > requirement. > > I understood you. I was arguing against your interpretation of heading contents. > > > Although it's not spelled out in the standard, heading contents (especially h1 > > h2 > h3 ...) is one of the most important elements for search engine > optimization. A "good" heading is typically made up of a short sentence > containing as many keywords as possible without duplication or spam (AFAIK). > > Example: http://bbc.com > > - All of the article titles are h1s on their respective pages > - All of the article titles are short (optimized?) sentences > > Of course, I will admit that "We want to make the internet better for everyone" > is not very "optimized". And that I think it really does make a better "tagline" > or "description" underneath a heading. But, perhaps, it is better than "About > Us" (the unfortunate title of this page and many others on the internet - > unfortunate because it's hard to compete over the keywords "about" and "us"). > > Therefore, I'm arguing that the proper implementation of this page consists of a > header containing the <h1> "We want to make the internet better for everyone." > and the subtitle <p> "Purging bad ads is a good start." > > - Acknowledging that we could make it all one h1 and <strong> the first part if > we wanted to optimize our SEO slightly at the expense of our accessibility > - Acknowledging that I would accept an sr-only h1 "eyeo" above the "tagline" > that we are arguing about as a compromise between both of our solutions > - But that would still not be a "good" solution IMO because it would be a > wasted opportunity to put more searchable contents within the h1 on our homepage Okay. I'm going with making the whole phrase the <h1>. Why do you think this is compromising the accessibility? juliandoucette 2018/01/30 04:22:19 I don't; on second thought. I think <strong> is a Show quoted text On 2018/01/26 10:11:00, ire wrote: > Okay. I'm going with making the whole phrase the <h1>. > > Why do you think this is compromising the accessibility? I don't; on second thought. I think <strong> is a reasonable implementation/compromise. My first thought went something like this: W3 recommends that we do sub-(titles/headings)/bylines like this[1]. These are clearly two sentences. One seems header like and the other seems byline like to me. But, this byline is more searchable than this header - so it would be nice to include it in the header for the sake of SEO in-case bylines in <header> elements are not given as much importance by search engines (I don't actually know). But I don't want to risk making these less semantically distinguishable as separate and title/subtitle like to screen readers. [1]: https://www.w3.org/TR/html51/sections.html#the-header-element ire 2018/01/30 07:20:03 Acknowledged. Show quoted text On 2018/01/30 04:22:19, juliandoucette wrote: > On 2018/01/26 10:11:00, ire wrote: > > Okay. I'm going with making the whole phrase the <h1>. > > > > Why do you think this is compromising the accessibility? > > I don't; on second thought. I think <strong> is a reasonable > implementation/compromise. > > My first thought went something like this: W3 recommends that we do > sub-(titles/headings)/bylines like this[1]. These are clearly two sentences. One > seems header like and the other seems byline like to me. But, this byline is > more searchable than this header - so it would be nice to include it in the > header for the sake of SEO in-case bylines in <header> elements are not given as > much importance by search engines (I don't actually know). But I don't want to > risk making these less semantically distinguishable as separate and > title/subtitle like to screen readers. > > [1]: https://www.w3.org/TR/html51/sections.html#the-header-element Acknowledged.
18 <img alt="eyeo office" src="/images/eyeo-home@1x.jpg" srcset="/images/eyeo-h ome@1,25x.jpg 1.25x, /images/eyeo-home@2x.jpg 2x" />	18 <img alt="eyeo office" src="/images/eyeo-home-1x.jpg" srcset="/images/eyeo-h ome-2x.jpg 2x" />
juliandoucette 2018/01/18 21:43:51 You included more images than you linked to in src You included more images than you linked to in srcset. ire 2018/01/19 09:16:27 Done. Show quoted text On 2018/01/18 21:43:51, juliandoucette wrote: > You included more images than you linked to in srcset. Done. juliandoucette 2018/01/22 16:06:01 We have not used these conventions before: 1. "@N We have not used these conventions before: 1. "@Nx" (the @ sign) 2. "N,NN" (the comma) I have used "-" instead of "@" and "." instead of ",". I am open to changing these conventions and I think we should be consistent. (I'm asking you to change it or request that we change the conventions.) ire 2018/01/25 11:54:14 If we were starting from scratch I would say that Show quoted text On 2018/01/22 16:06:01, juliandoucette wrote: > We have not used these conventions before: > > 1. "@Nx" (the @ sign) > 2. "N,NN" (the comma) > > I have used "-" instead of "@" and "." instead of ",". I am open to changing > these conventions and I think we should be consistent. > > (I'm asking you to change it or request that we change the conventions.) If we were starting from scratch I would say that the @N,Nx format is cleaner, particularly when there are decimals involved. However, in this case I'll go with the -Nx format since 1) I'm not using decimals here so the advantage isn't relevant 2) I don't think the @N,Nx format is that much more superior, if I feel more strongly about it I'll bring it up to change it in the future juliandoucette 2018/01/25 14:27:29 RE: 2 - Feel free. If the "@" and "," don't have a Show quoted text On 2018/01/25 11:54:14, ire wrote: > If we were starting from scratch I would say that the @N,Nx format is cleaner, > particularly when there are decimals involved. However, in this case I'll go > with the -Nx format since 1) I'm not using decimals here so the advantage isn't > relevant 2) I don't think the @N,Nx format is that much more superior, if I > feel more strongly about it I'll bring it up to change it in the future RE: 2 - Feel free. If the "@" and "," don't have any negative side effects other than being "different" then it seems like you can/are making a good case for them (and we can change format across the board separately). ire 2018/01/26 10:11:00 Cool, agreed. Show quoted text On 2018/01/25 14:27:29, juliandoucette wrote: > On 2018/01/25 11:54:14, ire wrote: > > If we were starting from scratch I would say that the @N,Nx format is cleaner, > > particularly when there are decimals involved. However, in this case I'll go > > with the -Nx format since 1) I'm not using decimals here so the advantage > isn't > > relevant 2) I don't think the @N,Nx format is that much more superior, if I > > feel more strongly about it I'll bring it up to change it in the future > > RE: 2 - Feel free. If the "@" and "," don't have any negative side effects other > than being "different" then it seems like you can/are making a good case for > them (and we can change format across the board separately). Cool, agreed.
19 <p>	19 <h1>

20 <strong>We want to make the internet better for everyone.</strong><br>	20 <strong>We want to make the internet better for everyone.</strong><br>
juliandoucette 2018/01/25 14:27:29 - They wanted "better for everyone" on a separate - They wanted "better for everyone" on a separate line IIRC - The position of the bounding box is changed - The strong text is less strong Will you please confirm/approve these things with Jeen (or Christiane)? ire 2018/01/26 10:11:00 I showed Jeen a demo of how it currently is and sh Show quoted text On 2018/01/25 14:27:29, juliandoucette wrote: > - They wanted "better for everyone" on a separate line IIRC > - The position of the bounding box is changed > - The strong text is less strong > > Will you please confirm/approve these things with Jeen (or Christiane)? I showed Jeen a demo of how it currently is and she have her approval of all 3 changes. juliandoucette 2018/01/30 04:22:19 NIT: Did you also happen to show her in-between si Show quoted text On 2018/01/26 10:11:00, ire wrote: > I showed Jeen a demo of how it currently is and she have her approval of all 3 > changes. NIT: Did you also happen to show her in-between sizes e.g. by demo and not screenshots? ire 2018/01/30 07:20:03 I showed her a [screen recording](https://drive.go Show quoted text On 2018/01/30 04:22:19, juliandoucette wrote: > On 2018/01/26 10:11:00, ire wrote: > > I showed Jeen a demo of how it currently is and she have her approval of all 3 > > changes. > > NIT: Did you also happen to show her in-between sizes e.g. by demo and not > screenshots? I showed her a [screen recording](https://drive.google.com/file/d/1WXXJb2Dj-YPXmjcCmMRnFdD6KlSJXPYy/view?usp=sharing) of me resizing from desktop to mobile, so she saw all the in-between stages as well
21 Purging bad ads is a good start.	21 Purging bad ads is a good start.

22 </p>	22 </h1>

23 </div>	23 </div>

24 </div>	24 </header>

25	25

26 <div id="who-we-are" class="content-block columns-container two-columns">	26 <div id="who-we-are" class="content-block columns-container two-columns">

27 <div class="column" markdown="1">	27 <div class="column" markdown="1">

28 <? include index/whoweare ?>	28 <? include index/whoweare ?>

29 </div>	29 </div>

30	30

31 <div class="column">	31 <div class="column">

32 <? include index/mission ?>	32 <? include index/mission ?>

33 </div>	33 </div>

34 </div>	34 </div>

(...skipping 18 matching lines...) Expand all Loading...
53 <div class="column">	53 <div class="column">

54 <? include index/ourwork-opensource ?>	54 <? include index/ourwork-opensource ?>

55 </div>	55 </div>

56 </div>	56 </div>

57 </div>	57 </div>

58 </div>	58 </div>

59	59

60 <div id="media" class="content-block">	60 <div id="media" class="content-block">

61 <? include index/media ?>	61 <? include index/media ?>

62 </div>	62 </div>

LEFT	RIGHT