third_party/libadblockplus_android/prepare_build_tools.py - Issue 29674555: Issue 6273 - Apply eyeo python code style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: third_party/libadblockplus_android/prepare_build_tools.py

Issue 29674555: Issue 6273 - Apply eyeo python code style (Closed)

Left Patch Set: Created Jan. 19, 2018, 7:28 a.m.

Right Patch Set: Removed sys.exit() where return code is always 0 Created Jan. 29, 2018, 12:50 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
	1 from __future__ import print_function

	2

1 import os	3 import os

2 import sys	4 import sys

3 import subprocess	5 import subprocess

4 import shutil	6 import shutil

5	7

6	8

7 def get_dst_path():	9 def get_dst_path():

8 cwd = os.getcwd()	10 cwd = os.getcwd()

9 return os.path.join(cwd, 'src', 'third_party',	11 return os.path.join(cwd, 'src', 'third_party',

10 'libadblockplus_android', 'third_party', 'android_sdk')	12 'libadblockplus_android', 'third_party', 'android_sdk')

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 if a16 != 0:	72 if a16 != 0:

71 return a16	73 return a16

72	74

73 a21 = install('Platform 21', 'platforms', 'android-21', True)	75 a21 = install('Platform 21', 'platforms', 'android-21', True)

74 if a21 != 0:	76 if a21 != 0:

75 return a21	77 return a21

76	78

77 return 0	79 return 0

78	80

79	81

80 if '__main__' == __name__:	82 if __name__ == '__main__':

81 try:	83 try:

82 sys.exit(main(sys.argv[1:]))	84 sys.exit(main(sys.argv[1:]))

83 except KeyboardInterrupt:	85 except KeyboardInterrupt:

84 sys.stderr.write('interrupted\n')	86 sys.exit('interrupted')

85 sys.exit(1)

LEFT	RIGHT