Issue 5549 - Implement missing error handlings for custom filter lists

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 323 matching lines @@
   modules.filterValidation =
   {
     parseFilter(text)
     {
       if (params.filterError)
         return {error: "Invalid filter"};
       return {filter: modules.filterClasses.Filter.fromText(text)};
     },
     parseFilters(text)
     {
       if (params.filterError)

[saroyanm, 2018/01/29 11:44:48]

Suggestion: copy pasting with the slight modification of current method ->
https://hg.adblockplus.org/adblockpluschrome/file/tip/lib/filterValidation.js...


Can help us making better test, ex.: Testing 5+ and less than 5 lines.

[a.giammarchi, 2018/01/29 17:36:32]

not sure I understand this one. What do you mean?
what would be the best way for doing that? the amount of errors through the
queryString?

[saroyanm, 2018/01/30 12:03:44]

We will try to use part of filterValidation in order to validate the filters and
we might get rid of "params.filterError".

-        return {errors: ["Invalid filter"]};
+        return {errors: [{reason: "Invalid filter", lineno: 1}]};
       return {
         filters: text.split("\n")
           .filter((filter) => !!filter)
           .map(modules.filterClasses.Filter.fromText),
         errors: []
       };
     }
   };
 
   modules.synchronizer = {
@@ skipping 256 matching lines @@
       },
       filter: {
         text: "||example.com/some-annoying-popup$popup",
         whitelisted: false,
         userDefined: true,
         subscription: null
       }
     });
   });
 }());