Issue 5549 - Implement missing error handlings for custom filter lists

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 251 matching lines @@
     return subscription.filters.map(convertFilter);
   });
 
   port.on("filters.importRaw", (message, sender) =>
   {
     let result = require("filterValidation").parseFilters(message.text);
     let errors = [];
     for (let error of result.errors)
     {
       if (error.type != "unexpected-filter-list-header")
-        errors.push(error.toString());
+      {
+        // passing along all the info available through the error object
+        // in case we'll ever need these extra info in the future
+        errors.push({
+          lineno: error.lineno,
+          reason: error.reason,
+          type: error.type
+        });
+      }
     }
 
     if (errors.length > 0)
       return errors;
 
     let seenFilter = Object.create(null);
     for (let filter of result.filters)
     {
       FilterStorage.addFilter(filter);
       seenFilter[filter.text] = null;
@@ skipping 173 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);