Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: skin/desktop-options.css

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: changed custom-filters-edit-area to custom-filters-control as suggested Created Feb. 5, 2018, 9:05 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « messageResponder.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 button.list:hover 212 button.list:hover
213 { 213 {
214 box-shadow: inset 0 0 0 3px #077CA6; 214 box-shadow: inset 0 0 0 3px #077CA6;
215 border-color: #077CA6; 215 border-color: #077CA6;
216 } 216 }
217 217
218 .side-controls:not(.wrap) 218 .side-controls:not(.wrap)
219 { 219 {
220 margin: 0.8rem 0rem; 220 margin: 0.8rem 0rem;
221 display: flex; 221 display: flex;
222 align-self: center;
222 justify-content: flex-end; 223 justify-content: flex-end;
223 } 224 }
224 225
225 .side-controls button 226 .side-controls button
226 { 227 {
227 margin: 0rem; 228 margin: 0rem;
228 -moz-margin-start: 1rem; 229 -moz-margin-start: 1rem;
229 -webkit-margin-start: 1rem; 230 -webkit-margin-start: 1rem;
230 } 231 }
231 232
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 538
538 #sidebar, 539 #sidebar,
539 #sidebar .fixed, 540 #sidebar .fixed,
540 [role="tablist"] 541 [role="tablist"]
541 { 542 {
542 width: 14.3rem; 543 width: 14.3rem;
543 } 544 }
544 545
545 #sidebar 546 #sidebar
546 { 547 {
547 flex-shrink: 0; 548 flex-shrink: 0;
548 } 549 }
549 550
550 #sidebar .fixed 551 #sidebar .fixed
551 { 552 {
552 top: 1.2rem; 553 top: 1.2rem;
553 bottom: 0rem; 554 bottom: 0rem;
554 height: auto; 555 height: auto;
555 } 556 }
556 557
557 #sidebar header 558 #sidebar header
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 /* 1128 /*
1128 Advanced tab content 1129 Advanced tab content
1129 */ 1130 */
1130 1131
1131 #all-filter-lists-table li.show-message .last-update, 1132 #all-filter-lists-table li.show-message .last-update,
1132 #all-filter-lists-table li:not(.show-message) .message, 1133 #all-filter-lists-table li:not(.show-message) .message,
1133 #custom-filters:not([data-mode="empty"]) #empty-custom-filters, 1134 #custom-filters:not([data-mode="empty"]) #empty-custom-filters,
1134 #custom-filters[data-mode="empty"] #custom-filters-raw, 1135 #custom-filters[data-mode="empty"] #custom-filters-raw,
1135 #custom-filters:not([data-mode="write"]) #custom-filters-raw-controls, 1136 #custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
1136 #custom-filters:not([data-mode="read"]) #custom-filters-edit, 1137 #custom-filters:not([data-mode="read"]) #custom-filters-edit,
1138 #custom-filters-error,
1137 .state span, 1139 .state span,
1138 #acceptable-ads:not(.show-dnt-notification) #dnt 1140 #acceptable-ads:not(.show-dnt-notification) #dnt
1139 { 1141 {
1140 display: none; 1142 display: none;
1141 } 1143 }
1142 1144
1143 #all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #s tate-active 1145 #all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #s tate-active,
1144 {
1145 display: inline;
1146 }
1147
1148 #all-filter-lists-table button[role="checkbox"][aria-checked="false"] + .state # state-disabled 1146 #all-filter-lists-table button[role="checkbox"][aria-checked="false"] + .state # state-disabled
1149 { 1147 {
1150 display: inline; 1148 display: inline;
1151 } 1149 }
1152 1150
1153 #all-filter-lists-table 1151 #all-filter-lists-table
1154 { 1152 {
1155 margin-bottom: 0.8rem; 1153 margin-bottom: 0.8rem;
1156 } 1154 }
1157 1155
1156 #custom-filters-edit
1157 {
1158 white-space: nowrap;
1159 }
1160
1161 #custom-filters-control
1162 {
1163 display: flex;
1164 width: 100%;
1165 }
1166
1167 /*
1168 avoid doubled margin glitchy behavior
1169 as shown in visual specifications
1170 */
1171 #custom-filters-control .side-controls .side-controls
1172 {
1173 margin: 0;
1174 }
1175
1176 /*
1177 visibility: hidden;
1178 preserves the flex-box meaning,
1179 keeping buttons on the right.
1180 */
1181 #custom-filters-edit-error
1182 {
1183 visibility: hidden;
1184 display: flex;
1185 align-self: center;
1186 justify-content: flex-start;
1187 font-weight: bold;
1188 }
1189
1190 #custom-filters.warning #custom-filters-edit-error,
1191 #custom-filters-error
1192 {
1193 color: #C11D26;
1194 padding: 0.2rem 0.8rem;
1195 }
1196
1197 #custom-filters.warning #custom-filters-edit-error
1198 {
1199 visibility: visible;
1200 }
1201
1202 #custom-filters-error
1203 {
1204 display: block;
1205 list-style: none;
1206 white-space: pre;
1207 overflow: auto;
1208 }
1209
1210 #custom-filters-error.many
1211 {
1212 border: 1px solid silver;
1213 max-height: 6.2rem;
1214 }
1215
1158 #custom-filters-raw 1216 #custom-filters-raw
1159 { 1217 {
1160 width: 100%; 1218 width: 100%;
1161 height: 23.6rem; 1219 height: 23.6rem;
1162 padding: 0.8rem; 1220 padding: 0.8rem;
1163 } 1221 }
1164 1222
1165 #custom-filters-raw:focus 1223 #custom-filters-raw:focus
1166 { 1224 {
1167 outline: none; 1225 outline: none;
1168 border: 2px solid #077CA6; 1226 border: 2px solid #077CA6;
1169 } 1227 }
1170 1228
1229 #custom-filters.warning #custom-filters-raw
1230 {
1231 outline: none;
1232 border: 2px solid #C11D26;
1233 }
1234
1171 #empty-custom-filters 1235 #empty-custom-filters
1172 { 1236 {
1173 padding: 1.5rem; 1237 padding: 1.5rem;
1174 border: 1px solid #CDCDCD; 1238 border: 1px solid #CDCDCD;
1175 } 1239 }
1176 1240
1177 /* 1241 /*
1178 Context menu 1242 Context menu
1179 */ 1243 */
1180 1244
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
1511 font-size: 1rem; 1575 font-size: 1rem;
1512 color: #077CA6; 1576 color: #077CA6;
1513 background-color: #E1F2FA; 1577 background-color: #E1F2FA;
1514 } 1578 }
1515 1579
1516 #notification strong 1580 #notification strong
1517 { 1581 {
1518 flex: 1; 1582 flex: 1;
1519 text-align: center; 1583 text-align: center;
1520 } 1584 }
OLDNEW
« no previous file with comments | « messageResponder.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld