Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/desktop-options.css

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Left Patch Set: using convertObject Created Jan. 30, 2018, 1:15 p.m.
Right Patch Set: changed custom-filters-edit-area to custom-filters-control as suggested Created Feb. 5, 2018, 9:05 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « messageResponder.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 textarea, 107 textarea,
108 main 108 main
109 { 109 {
110 -webkit-box-sizing: border-box; 110 -webkit-box-sizing: border-box;
111 -moz-box-sizing: border-box; 111 -moz-box-sizing: border-box;
112 box-sizing: border-box; 112 box-sizing: border-box;
113 } 113 }
114 114
115 /* 115 /*
116 Normalization 116 Normalization
117 */ 117 */
118 118
119 input, 119 input,
120 button 120 button
121 { 121 {
122 font-family: inherit; 122 font-family: inherit;
123 } 123 }
124 124
125 button 125 button
126 { 126 {
127 border-radius: 0rem; 127 border-radius: 0rem;
128 } 128 }
129 129
130 /* 130 /*
131 Buttons and links 131 Buttons and links
132 */ 132 */
133 133
134 button, 134 button,
135 .button 135 .button
136 { 136 {
137 display: block; 137 display: block;
138 padding: 0.6rem 0.8rem; 138 padding: 0.6rem 0.8rem;
139 background-color: transparent; 139 background-color: transparent;
140 font-size: 1rem; 140 font-size: 1rem;
141 font-weight: 700; 141 font-weight: 700;
142 text-decoration: none; 142 text-decoration: none;
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 232
233 .side-controls.wrap button 233 .side-controls.wrap button
234 { 234 {
235 margin: 0.6rem 0rem; 235 margin: 0.6rem 0rem;
236 -moz-margin-start: auto; 236 -moz-margin-start: auto;
237 -webkit-margin-start: auto; 237 -webkit-margin-start: auto;
238 } 238 }
239 239
240 /* 240 /*
241 icons 241 icons
242 */ 242 */
243 243
244 .icon 244 .icon
245 { 245 {
246 border: 0px; 246 border: 0px;
247 padding: 0px; 247 padding: 0px;
248 background-color: transparent; 248 background-color: transparent;
249 } 249 }
250 250
251 .icon:hover 251 .icon:hover
252 { 252 {
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 background-image: url("social/facebook.svg"); 445 background-image: url("social/facebook.svg");
446 } 446 }
447 447
448 .icon#google-plus::before 448 .icon#google-plus::before
449 { 449 {
450 background-image: url("social/googleplus.svg"); 450 background-image: url("social/googleplus.svg");
451 } 451 }
452 452
453 /* 453 /*
454 Forms 454 Forms
455 */ 455 */
456 456
457 .floating-input 457 .floating-input
458 { 458 {
459 position: relative; 459 position: relative;
460 padding-top: 0.7rem; 460 padding-top: 0.7rem;
461 margin: 1.8rem 0rem 0.5rem 0rem; 461 margin: 1.8rem 0rem 0.5rem 0rem;
462 } 462 }
463 463
464 .floating-input input 464 .floating-input input
465 { 465 {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 visibility: hidden; 527 visibility: hidden;
528 } 528 }
529 529
530 [data-validation] .floating-input input:focus:invalid ~ .error-msg 530 [data-validation] .floating-input input:focus:invalid ~ .error-msg
531 { 531 {
532 visibility: visible; 532 visibility: visible;
533 } 533 }
534 534
535 /* 535 /*
536 Sidebar 536 Sidebar
537 */ 537 */
538 538
539 #sidebar, 539 #sidebar,
540 #sidebar .fixed, 540 #sidebar .fixed,
541 [role="tablist"] 541 [role="tablist"]
542 { 542 {
543 width: 14.3rem; 543 width: 14.3rem;
544 } 544 }
545 545
546 #sidebar 546 #sidebar
547 { 547 {
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 #sidebar .fixed 654 #sidebar .fixed
655 { 655 {
656 position: fixed; 656 position: fixed;
657 } 657 }
658 658
659 #sidebar footer 659 #sidebar footer
660 { 660 {
661 bottom: 0px; 661 bottom: 0px;
662 position: absolute; 662 position: absolute;
663 } 663 }
664
665 } 664 }
666 665
667 /* 666 /*
668 Main content 667 Main content
669 */ 668 */
670 669
671 body[data-tab|="general"] #content-general, 670 body[data-tab|="general"] #content-general,
672 body[data-tab|="advanced"] #content-advanced, 671 body[data-tab|="advanced"] #content-advanced,
673 body[data-tab|="whitelist"] #content-whitelist, 672 body[data-tab|="whitelist"] #content-whitelist,
674 body[data-tab|="help"] #content-help 673 body[data-tab|="help"] #content-help
675 { 674 {
676 display: block; 675 display: block;
677 } 676 }
678 677
679 main 678 main
680 { 679 {
681 background-color: #FFFFFF; 680 background-color: #FFFFFF;
682 border: 1px solid #CDCDCD; 681 border: 1px solid #CDCDCD;
683 width: 46.3rem; 682 width: 46.3rem;
684 padding: 0px 0rem 1.4rem 0rem; 683 padding: 0px 0rem 1.4rem 0rem;
685 } 684 }
686 685
687 main > div 686 main > div
688 { 687 {
689 display: none; 688 display: none;
690 } 689 }
691 690
692 main p 691 main p
693 { 692 {
694 margin: 0.8rem 0rem; 693 margin: 0.8rem 0rem;
695 } 694 }
696 695
697 /* 696 /*
698 Sections 697 Sections
699 */ 698 */
700 699
701 [role="tabpanel"] > section, 700 [role="tabpanel"] > section,
702 [role="tabpanel"] > .section 701 [role="tabpanel"] > .section
703 { 702 {
704 padding: 1.4rem 2rem; 703 padding: 1.4rem 2rem;
705 border-top: 1px solid #CDCDCD; 704 border-top: 1px solid #CDCDCD;
706 } 705 }
707 706
708 [role="tabpanel"] > header h1, 707 [role="tabpanel"] > header h1,
709 [role="tabpanel"] > header p 708 [role="tabpanel"] > header p
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 -webkit-margin-end: 2rem; 740 -webkit-margin-end: 2rem;
742 } 741 }
743 742
744 section.cols > *:last-child 743 section.cols > *:last-child
745 { 744 {
746 flex: 3; 745 flex: 3;
747 } 746 }
748 747
749 /* 748 /*
750 Acceptable ads 749 Acceptable ads
751 */ 750 */
752 751
753 #tracking-warning 752 #tracking-warning
754 { 753 {
755 position: relative; 754 position: relative;
756 padding: 1.5rem; 755 padding: 1.5rem;
757 margin-bottom: 1rem; 756 margin-bottom: 1rem;
758 border: 2px solid #ffd7a3; 757 border: 2px solid #ffd7a3;
759 background-color: #fefbe3; 758 background-color: #fefbe3;
760 } 759 }
761 760
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 border-radius: 0.2rem; 829 border-radius: 0.2rem;
831 background-color: #077CA6; 830 background-color: #077CA6;
832 color: #FFF; 831 color: #FFF;
833 line-height: 100%; 832 line-height: 100%;
834 font-size: 0.8rem; 833 font-size: 0.8rem;
835 text-transform: uppercase; 834 text-transform: uppercase;
836 } 835 }
837 836
838 /* 837 /*
839 Tables 838 Tables
840 */ 839 */
841 840
842 ul.table, 841 ul.table,
843 ul.list 842 ul.list
844 { 843 {
845 list-style: none; 844 list-style: none;
846 margin: 0rem; 845 margin: 0rem;
847 padding: 0rem; 846 padding: 0rem;
848 } 847 }
849 848
850 .table li, 849 .table li,
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 .button-add, .cancel-button 1088 .button-add, .cancel-button
1090 { 1089 {
1091 background-color: transparent; 1090 background-color: transparent;
1092 border: 0px; 1091 border: 0px;
1093 color: #3A7BA6; 1092 color: #3A7BA6;
1094 cursor: pointer; 1093 cursor: pointer;
1095 } 1094 }
1096 1095
1097 /* 1096 /*
1098 Whitelist tab 1097 Whitelist tab
1099 */ 1098 */
1100 1099
1101 #content-whitelist form 1100 #content-whitelist form
1102 { 1101 {
1103 display: flex; 1102 display: flex;
1104 } 1103 }
1105 1104
1106 #content-whitelist form input 1105 #content-whitelist form input
1107 { 1106 {
1108 flex: 1; 1107 flex: 1;
1109 height: 100%; 1108 height: 100%;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 #all-filter-lists-table 1151 #all-filter-lists-table
1153 { 1152 {
1154 margin-bottom: 0.8rem; 1153 margin-bottom: 0.8rem;
1155 } 1154 }
1156 1155
1157 #custom-filters-edit 1156 #custom-filters-edit
1158 { 1157 {
1159 white-space: nowrap; 1158 white-space: nowrap;
1160 } 1159 }
1161 1160
1162 #custom-filters-edit-area 1161 #custom-filters-control
1163 { 1162 {
1164 display: flex; 1163 display: flex;
1165 width: 100%; 1164 width: 100%;
1166 } 1165 }
1167 1166
1168 /* 1167 /*
1169 avoid doubled margin glitchy behavior 1168 avoid doubled margin glitchy behavior
1170 as shown in visual specifications 1169 as shown in visual specifications
1171 */ 1170 */
1172 #custom-filters-edit-area .side-controls .side-controls 1171 #custom-filters-control .side-controls .side-controls
1173 { 1172 {
1174 margin: 0; 1173 margin: 0;
1175 } 1174 }
1176 1175
1177 /* 1176 /*
1178 visibility: hidden; 1177 visibility: hidden;
1179 preserves the flex-box meaning, 1178 preserves the flex-box meaning,
1180 keeping buttons on the right. 1179 keeping buttons on the right.
1181 */ 1180 */
1182 #custom-filters-edit-error 1181 #custom-filters-edit-error
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 } 1233 }
1235 1234
1236 #empty-custom-filters 1235 #empty-custom-filters
1237 { 1236 {
1238 padding: 1.5rem; 1237 padding: 1.5rem;
1239 border: 1px solid #CDCDCD; 1238 border: 1px solid #CDCDCD;
1240 } 1239 }
1241 1240
1242 /* 1241 /*
1243 Context menu 1242 Context menu
1244 */ 1243 */
1245 1244
1246 li [role="menubar"] 1245 li [role="menubar"]
1247 { 1246 {
1248 position: relative; 1247 position: relative;
1249 } 1248 }
1250 1249
1251 [role="tooltip"] 1250 [role="tooltip"]
1252 { 1251 {
1253 right: -0.8rem; 1252 right: -0.8rem;
1254 margin-top: 0.8rem; 1253 margin-top: 0.8rem;
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1404 1403
1405 #social ul 1404 #social ul
1406 { 1405 {
1407 list-style: none; 1406 list-style: none;
1408 padding: 0px; 1407 padding: 0px;
1409 } 1408 }
1410 1409
1411 #social ul li 1410 #social ul li
1412 { 1411 {
1413 display: inline-block; 1412 display: inline-block;
1414 margin-right: 1rem;
1415 -moz-margin-end: 1rem; 1413 -moz-margin-end: 1rem;
1416 -webkit-margin-end: 1rem; 1414 -webkit-margin-end: 1rem;
1417 } 1415 }
1418 1416
1419 #social ul li a 1417 #social ul li a
1420 { 1418 {
1421 display: block; 1419 display: block;
1422 text-align: center; 1420 text-align: center;
1423 text-decoration: none; 1421 text-decoration: none;
1424 } 1422 }
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 font-size: 1rem; 1575 font-size: 1rem;
1578 color: #077CA6; 1576 color: #077CA6;
1579 background-color: #E1F2FA; 1577 background-color: #E1F2FA;
1580 } 1578 }
1581 1579
1582 #notification strong 1580 #notification strong
1583 { 1581 {
1584 flex: 1; 1582 flex: 1;
1585 text-align: center; 1583 text-align: center;
1586 } 1584 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld