Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: desktop-options.js

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Left Patch Set: applied almost all changes Created Feb. 2, 2018, 1:09 p.m.
Right Patch Set: changed custom-filters-edit-area to custom-filters-control as suggested Created Feb. 5, 2018, 9:05 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « desktop-options.html ('k') | locale/en_US/desktop-options.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 1177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1188 special: true 1188 special: true
1189 }, 1189 },
1190 (subscriptions) => 1190 (subscriptions) =>
1191 { 1191 {
1192 // Load filters 1192 // Load filters
1193 for (let subscription of subscriptions) 1193 for (let subscription of subscriptions)
1194 { 1194 {
1195 browser.runtime.sendMessage({ 1195 browser.runtime.sendMessage({
1196 type: "filters.get", 1196 type: "filters.get",
1197 subscriptionUrl: subscription.url 1197 subscriptionUrl: subscription.url
1198 }, 1198 }, loadCustomFilters);
1199 (filters) =>
1200 {
1201 loadCustomFilters(filters);
1202 });
1203 } 1199 }
1204 }); 1200 });
1205 loadRecommendations(); 1201 loadRecommendations();
1206 browser.runtime.sendMessage({ 1202 browser.runtime.sendMessage({
1207 type: "prefs.get", 1203 type: "prefs.get",
1208 key: "subscriptions_exceptionsurl" 1204 key: "subscriptions_exceptionsurl"
1209 }, 1205 },
1210 (url) => 1206 (url) =>
1211 { 1207 {
1212 acceptableAdsUrl = url; 1208 acceptableAdsUrl = url;
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 }); 1502 });
1507 browser.runtime.sendMessage({ 1503 browser.runtime.sendMessage({
1508 type: "subscriptions.listen", 1504 type: "subscriptions.listen",
1509 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1505 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1510 "title", "downloadStatus", "downloading"] 1506 "title", "downloadStatus", "downloading"]
1511 }); 1507 });
1512 1508
1513 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1509 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1514 window.addEventListener("hashchange", onHashChange, false); 1510 window.addEventListener("hashchange", onHashChange, false);
1515 } 1511 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld