Issue 5549 - Implement missing error handlings for custom filter lists

skin/desktop-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 643 matching lines @@
   #sidebar .fixed
   {
     position: fixed;
   }
 
   #sidebar footer
   {
     bottom: 0px;
     position: absolute;
   }
-

[saroyanm, 2018/02/02 16:57:20]

Nit: I think this is again an IDE auto-correction.

 }
 
 /*
   Main content
  */
 
 body[data-tab|="general"] #content-general,
 body[data-tab|="advanced"] #content-advanced,
 body[data-tab|="whitelist"] #content-whitelist,
 body[data-tab|="help"] #content-help
@@ skipping 477 matching lines @@
 #all-filter-lists-table
 {
   margin-bottom: 0.8rem;
 }
 
 #custom-filters-edit
 {
   white-space: nowrap;
 }
 
-#custom-filters-edit-area
+#custom-filters-control
 {
   display: flex;
   width: 100%;
 }
 
 /*
   avoid doubled margin glitchy behavior
   as shown in visual specifications
 */
-#custom-filters-edit-area .side-controls .side-controls
+#custom-filters-control .side-controls .side-controls
 {
   margin: 0;
 }
 
 /*
   visibility: hidden;
   preserves the flex-box meaning,
   keeping buttons on the right.
 */
 #custom-filters-edit-error
@@ skipping 221 matching lines @@
 
 #social ul
 {
   list-style: none;
   padding: 0px;
 }
 
 #social ul li
 {
   display: inline-block;
-  margin-right: 1rem;

[saroyanm, 2018/02/02 16:57:20]

Why was this change necessary ?
We already had end margin specified.

[a.giammarchi, 2018/02/02 17:22:00]

We cannot use margin-end because it's not compatible with Edge.
This part was not covered by the other ticket that will remove following
margin-end from this file.

I'm fixing issues knowing already there will be one (tested on Edge)

[saroyanm, 2018/02/02 17:58:57]

Right, we have created issue #5813 to tackle that.
The problem with tackling it here, we will need to be sure that we consider RTL
languages, so this will probably require having a hack like:
html[dir="rtl"] #social ul li
{
  margin-left: 1rem;
}

and also removal of margin-end. While we need to tackle that not only for social
media buttons, but we are using margin-end and padding-end in a lot of places,
I'll suggest to leave it for #5813.

   -moz-margin-end: 1rem;
   -webkit-margin-end: 1rem;
 }
 
 #social ul li a
 {
   display: block;
   text-align: center;
   text-decoration: none;
 }
@@ skipping 152 matching lines @@
   font-size: 1rem;
   color: #077CA6;
   background-color: #E1F2FA;
 }
 
 #notification strong
 {
   flex: 1;
   text-align: center;
 }