Unified Diff: desktop-options.html
Issue 29674584:
Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: fixed linting typos
Created Jan. 23, 2018, 10:46 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -29,7 +29,7 @@ |
| <script src="i18n.js"></script> |
| <script src="desktop-options.js"></script> |
| </head> |
| - <body data-tab="general"> |
| + <body data-tab="general" dir="rtl"> |
|
saroyanm
2018/01/23 15:26:05
Why direction RTL ?
BTW we do specify the directi
a.giammarchi
2018/01/23 15:43:18
oh gosh that's a "me trying things and not cleanin
|
| <!-- Navigation sidebar --> |
| <div id="sidebar"> |
| <div class="fixed"> |
| @@ -289,6 +289,9 @@ |
| <header> |
| <h2 class="i18n_options_customFilters_title"></h2> |
| <p class="i18n_options_customFilters_description"></p> |
| + <p> |
| + <a class="i18n_options_customFilters_learn" id="link-filters-on-edit-error" target="_blank"></a> |
|
saroyanm
2018/01/23 15:26:05
In general we use text specified in the specificat
a.giammarchi
2018/01/23 15:43:18
I've just followed visual specs here, I probably s
|
| + </p> |
| </header> |
| <div id="custom-filters"> |
| <h3 class="i18n_options_customFilters_widget_title"></h3> |
| @@ -301,14 +304,18 @@ |
| </p> |
| </div> |
| <textarea id="custom-filters-raw" rows="15"></textarea> |
| - <div class="side-controls"> |
| - <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters"> |
| - </button> |
| - <div class="side-controls" id="custom-filters-raw-controls"> |
| - <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button> |
| - <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button> |
| + <div id="custom-filters-edit-area"> |
| + <div id="custom-filters-edit-error" class="i18n_options_customFilters_edit_error"></div> |
| + <div class="side-controls"> |
| + <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters"> |
| + </button> |
| + <div id="custom-filters-raw-controls" class="side-controls"> |
| + <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button> |
| + <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button> |
| + </div> |
| </div> |
| </div> |
| + <div id="custom-filters-edit-filters"></div> |
| </div> |
| </section> |
| </div> |
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
