Unified Diff: messageResponder.js
Issue 29674584:
Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: enabled testing via ?filterError=true
Created Jan. 25, 2018, 12:56 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« desktop-options.js ('K')
|
« locale/en_US/desktop-options.json ('k')
|
skin/desktop-options.css » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: messageResponder.js |
| =================================================================== |
| --- a/messageResponder.js |
| +++ b/messageResponder.js |
| @@ -269,7 +269,15 @@ |
| for (let error of result.errors) |
| { |
| if (error.type != "unexpected-filter-list-header") |
| - errors.push(error.toString()); |
| + { |
| + // passing along all the info available through the error object |
| + // in case we'll ever need these extra info in the future |
| + errors.push({ |
|
saroyanm
2018/01/29 11:44:48
Detail: Why not just pass "error" Object ?
errors.
a.giammarchi
2018/01/29 17:36:32
I've missed this: because it comes from a class un
saroyanm
2018/01/30 12:03:44
@Thomas, can you please let me know what is the re
Thomas Greiner
2018/01/30 13:08:59
We can only pass plain objects using the messaging
|
| + lineno: error.lineno, |
| + reason: error.reason, |
| + type: error.type |
| + }); |
| + } |
| } |
| if (errors.length > 0) |
« desktop-options.js ('K')
|
« locale/en_US/desktop-options.json ('k')
|
skin/desktop-options.css » ('j')
|
no next file with comments »
