Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: background.js

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: changes as requested Created Jan. 30, 2018, 9:39 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | desktop-options.html » ('j') | desktop-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -342,7 +342,7 @@
parseFilters(text)
{
if (params.filterError)
- return {errors: ["Invalid filter"]};
+ return {errors: [{reason: "Invalid filter", lineno: 1}]};
return {
filters: text.split("\n")
.filter((filter) => !!filter)
« no previous file with comments | « no previous file | desktop-options.html » ('j') | desktop-options.js » ('J')

Powered by Google App Engine
This is Rietveld