Issue 5549 - Implement missing error handlings for custom filter lists

skin/desktop-options.css

Index: skin/desktop-options.css
===================================================================
--- a/skin/desktop-options.css
+++ b/skin/desktop-options.css
@@ -219,6 +219,7 @@
 {
   margin: 0.8rem 0rem;
   display: flex;
+  align-self: center;
   justify-content: flex-end;
 }
 
@@ -544,7 +545,7 @@
 
 #sidebar
 {
-  flex-shrink: 0; 
+  flex-shrink: 0;
 }
 
 #sidebar .fixed
@@ -660,6 +661,7 @@
     bottom: 0px;
     position: absolute;
   }
+

[saroyanm, 2018/02/02 16:57:20]

Nit: I think this is again an IDE auto-correction.

 }
 
 /*
@@ -1134,17 +1136,14 @@
 #custom-filters[data-mode="empty"] #custom-filters-raw,
 #custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
 #custom-filters:not([data-mode="read"]) #custom-filters-edit,
+#custom-filters-error,
 .state span,
 #acceptable-ads:not(.show-dnt-notification) #dnt
 {
   display: none;
 }
 
-#all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #state-active
-{
-  display: inline;
-}
-
+#all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #state-active,
 #all-filter-lists-table button[role="checkbox"][aria-checked="false"] + .state #state-disabled
 {
   display: inline;
@@ -1155,11 +1154,71 @@
   margin-bottom: 0.8rem;
 }
 
+#custom-filters-edit
+{
+  white-space: nowrap;
+}
+
+#custom-filters-edit-area
+{
+  display: flex;
+  width: 100%;
+}
+
+/*
+  avoid doubled margin glitchy behavior
+  as shown in visual specifications
+*/
+#custom-filters-edit-area .side-controls .side-controls
+{
+  margin: 0;
+}
+
+/*
+  visibility: hidden;
+  preserves the flex-box meaning,
+  keeping buttons on the right.
+*/
+#custom-filters-edit-error
+{
+  visibility: hidden;
+  display: flex;
+  align-self: center;
+  justify-content: flex-start;
+  font-weight: bold;
+}
+
+#custom-filters.warning #custom-filters-edit-error,
+#custom-filters-error
+{
+  color: #C11D26;
+  padding: 0.2rem 0.8rem;
+}
+
+#custom-filters.warning #custom-filters-edit-error
+{
+  visibility: visible;
+}
+
+#custom-filters-error
+{
+  display: block;
+  list-style: none;
+  white-space: pre;
+  overflow: auto;
+}
+
+#custom-filters-error.many
+{
+  border: 1px solid silver;
+  max-height: 6.2rem;
+}
+
 #custom-filters-raw
 {
   width: 100%;
   height: 23.6rem;
-  padding: 0.8rem; 
+  padding: 0.8rem;
 }
 
 #custom-filters-raw:focus
@@ -1168,6 +1227,12 @@
   border: 2px solid #077CA6;
 }
 
+#custom-filters.warning #custom-filters-raw
+{
+  outline: none;
+  border: 2px solid #C11D26;
+}
+
 #empty-custom-filters
 {
   padding: 1.5rem;
@@ -1346,6 +1411,7 @@
 #social ul li
 {
   display: inline-block;
+  margin-right: 1rem;

[saroyanm, 2018/02/02 16:57:20]

Why was this change necessary ?
We already had end margin specified.

[a.giammarchi, 2018/02/02 17:22:00]

We cannot use margin-end because it's not compatible with Edge.
This part was not covered by the other ticket that will remove following
margin-end from this file.

I'm fixing issues knowing already there will be one (tested on Edge)

[saroyanm, 2018/02/02 17:58:57]

Right, we have created issue #5813 to tackle that.
The problem with tackling it here, we will need to be sure that we consider RTL
languages, so this will probably require having a hack like:
html[dir="rtl"] #social ul li
{
  margin-left: 1rem;
}

and also removal of margin-end. While we need to tackle that not only for social
media buttons, but we are using margin-end and padding-end in a lot of places,
I'll suggest to leave it for #5813.

   -moz-margin-end: 1rem;
   -webkit-margin-end: 1rem;
 }