Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: messageResponder.js

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: applied changes Created Feb. 2, 2018, 5:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « locale/en_US/desktop-options.json ('k') | skin/desktop-options.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: messageResponder.js
===================================================================
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -269,7 +269,9 @@
for (let error of result.errors)
{
if (error.type != "unexpected-filter-list-header")
- errors.push(error.toString());
+ {
+ errors.push(convertObject(["lineno", "reason"], error));
+ }
}
if (errors.length > 0)
« no previous file with comments | « locale/en_US/desktop-options.json ('k') | skin/desktop-options.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld