Issue 6289 - Fix OnSharedPreferenceChangeListener

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 196 matching lines @@
         ? getString(R.string.add_subscription_dialog_message)
         : getString(R.string.remove_subscription_dialog_message));
   }
 
   @Override
   public void subscriptionUpdatedApplied()
   {
     this.dismissDialog();
   }
 
-  private SharedPrefsUtils.OnSharedPreferenceChangeListener listener =

[diegocarloslima, 2018/01/19 14:26:10]

It's better to be final

[jens, 2018/01/19 14:36:07]

Acknowledged.

+  private final SharedPrefsUtils.OnSharedPreferenceChangeListener listener =
       new SharedPrefsUtils.OnSharedPreferenceChangeListener()
   {
     @Override
     protected void onSharedPreferenceChanged(String key)
     {
       if (getString(R.string.key_automatic_updates).equals(key) && engine != null)
       {
         engine.connectivityChanged();
       }
       else if (getString(R.string.key_acceptable_ads).equals(key))
       {
         final boolean enabled = SharedPrefsUtils.getBoolean
             (MainPreferences.this, R.string.key_acceptable_ads, true);
         final String id = "url:" + engine.getPrefsDefault(Engine.SUBSCRIPTIONS_EXCEPTIONSURL);
         Log.d(TAG, "Acceptable ads " + (enabled ? "enabled" : "disabled"));
         engine.changeSubscriptionState(id, enabled);
       }
       else if (getString(R.string.key_application_activated).equals(key))
       {
         if (dialogTitleResId == R.string.setup_dialog_title)
         {
           dismissDialog();
         }
       }
     }
   };
 }