package.json - Issue 29677659: Issue #6303 - Introduce basic foundation for automation in adblockplusui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: package.json

Issue 29677659: Issue #6303 - Introduce basic foundation for automation in adblockplusui (Closed)

Patch Set: Created Feb. 7, 2018, 10:07 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 "name": "adblockplusui",

	3 "private": true,

	4 "description": "Adblock Plus UI",

	5 "scripts": {

	6 "lint": "npm run lint:js",

	7 "lint:js": "eslint ./.js ./lib/.js ./ext/*.js",

	8 "prepare": "python2 ensure_dependencies.py",

	9 "start": "http-server \"${@:2}\""
	saroyanm 2018/02/07 11:48:26 I'm getting an error "sh: 1: Bad substitution" wh I'm getting an error "sh: 1: Bad substitution" when running `npm start` saroyanm 2018/02/07 12:08:16 Bash version -> "4.3.11(1)-release (x86_64-pc-linu Show quoted text On 2018/02/07 11:48:26, saroyanm wrote: > I'm getting an error "sh: 1: Bad substitution" > > when running `npm start` Bash version -> "4.3.11(1)-release (x86_64-pc-linux-gnu)" saroyanm 2018/02/07 14:02:04 I've updated to 4.4.0(1)-release but still same i Show quoted text On 2018/02/07 12:08:16, saroyanm wrote: > On 2018/02/07 11:48:26, saroyanm wrote: > > I'm getting an error "sh: 1: Bad substitution" > > > > when running `npm start` > > Bash version -> "4.3.11(1)-release (x86_64-pc-linux-gnu)" I've updated to 4.4.0(1)-release but still same issue, can you please confirm that @Thomas can you please confirm that you are using the latest patch ? saroyanm 2018/02/07 14:21:41 Note: "start": "http-server '${@:2}'" Fixes the is Show quoted text On 2018/02/07 14:02:04, saroyanm wrote: > On 2018/02/07 12:08:16, saroyanm wrote: > > On 2018/02/07 11:48:26, saroyanm wrote: > > > I'm getting an error "sh: 1: Bad substitution" > > > > > > when running `npm start` > > > > Bash version -> "4.3.11(1)-release (x86_64-pc-linux-gnu)" > > I've updated to 4.4.0(1)-release but still same issue, can you please confirm > that @Thomas can you please confirm that you are using the latest patch ? Note: "start": "http-server '${@:2}'" Fixes the issue for me. a.giammarchi 2018/02/07 14:30:04 OK this is an issue with npm using sh, not bash, a Show quoted text On 2018/02/07 14:21:41, saroyanm wrote: > On 2018/02/07 14:02:04, saroyanm wrote: > > On 2018/02/07 12:08:16, saroyanm wrote: > > > On 2018/02/07 11:48:26, saroyanm wrote: > > > > I'm getting an error "sh: 1: Bad substitution" > > > > > > > > when running `npm start` > > > > > > Bash version -> "4.3.11(1)-release (x86_64-pc-linux-gnu)" > > > > I've updated to 4.4.0(1)-release but still same issue, can you please confirm > > that @Thomas can you please confirm that you are using the latest patch ? > > Note: "start": "http-server '${@:2}'" > Fixes the issue for me. OK this is an issue with npm using sh, not bash, and sh in macOS has backslashes inconsistencies compared to Linux. The "force bash" way to go is to pass: bash -c \"http-server ${@:2}\" but this becomes an ugly indirection of just http-server Thomas suggested we just pass along arguments through -- as in: npm start -- -p 5000 which is fine. I am updating script and documentation about this. Sorry for the inconvenience. saroyanm 2018/02/07 14:31:42 Sounds good, thanks. Show quoted text On 2018/02/07 14:30:04, a.giammarchi wrote: > On 2018/02/07 14:21:41, saroyanm wrote: > > On 2018/02/07 14:02:04, saroyanm wrote: > > > On 2018/02/07 12:08:16, saroyanm wrote: > > > > On 2018/02/07 11:48:26, saroyanm wrote: > > > > > I'm getting an error "sh: 1: Bad substitution" > > > > > > > > > > when running `npm start` > > > > > > > > Bash version -> "4.3.11(1)-release (x86_64-pc-linux-gnu)" > > > > > > I've updated to 4.4.0(1)-release but still same issue, can you please > confirm > > > that @Thomas can you please confirm that you are using the latest patch ? > > > > Note: "start": "http-server '${@:2}'" > > Fixes the issue for me. > > OK this is an issue with npm using sh, not bash, and sh in macOS has backslashes > inconsistencies compared to Linux. > > The "force bash" way to go is to pass: > bash -c \"http-server ${@:2}\" > but this becomes an ugly indirection of just http-server > > Thomas suggested we just pass along arguments through -- as in: > > npm start -- -p 5000 > > which is fine. > > I am updating script and documentation about this. > Sorry for the inconvenience. Sounds good, thanks.
	10 },

	11 "devDependencies": {

	12 "eslint": "^4.16.0",

	13 "eslint-config-eyeo": "^2.0.0",

	14 "http-server": "^0.11.1"

	15 }

	16 }

OLD	NEW

« README.md ('K') | « README.md ('k') | test_server.py » ('j') | no next file with comments »