Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29677724: Noissue - make parse_line and parse_filterlist also support byte strings (Closed)

Created:
Jan. 23, 2018, 4:30 p.m. by Vasily Kuznetsov
Modified:
Jan. 26, 2018, 5:15 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Noissue - make parse_line and parse_filterlist also support byte strings Repository: https://hg.adblockplus.org/python-abp Base revision: 735719150857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M abp/filters/parser.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/test_parser.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Vasily Kuznetsov
At the moment `parse_line` and `parse_filterlist` require their arguments to be unicode strings. This is ...
Jan. 23, 2018, 4:37 p.m. (2018-01-23 16:37:07 UTC) #1
mathias
Jan. 26, 2018, 11:57 a.m. (2018-01-26 11:57:17 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld