Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Issue 29677728: Issue 6305 - Do not nullify storage on engine disposed (Closed)
Patch Set: Created Jan. 23, 2018, 7:17 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 Log.w(TAG, "No saved adblock settings"); 75 Log.w(TAG, "No saved adblock settings");
76 } 76 }
77 } 77 }
78 }; 78 };
79 79
80 private final Runnable engineDisposedCallback = new Runnable() 80 private final Runnable engineDisposedCallback = new Runnable()
81 { 81 {
82 @Override 82 @Override
83 public void run() 83 public void run()
84 { 84 {
85 Log.d(TAG, "Releasing adblock settings storage"); 85 Log.d(TAG, "Adblock engine disposed");
86 storage = null;
87 } 86 }
88 }; 87 };
89 88
90 // singleton 89 // singleton
91 protected AdblockHelper() 90 protected AdblockHelper()
92 { 91 {
93 // prevents instantiation 92 // prevents instantiation
94 } 93 }
95 94
96 /** 95 /**
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 199
201 /** 200 /**
202 * @deprecated The method is deprecated: use .getProvider().getCounter() inste ad 201 * @deprecated The method is deprecated: use .getProvider().getCounter() inste ad
203 */ 202 */
204 @Deprecated 203 @Deprecated
205 public int getCounter() 204 public int getCounter()
206 { 205 {
207 return provider.getCounter(); 206 return provider.getCounter();
208 } 207 }
209 } 208 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld