Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(426)

Issue 29677755: Issue 6279 - Make HashContainer movable and optimize resizing by moving entries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by hub
Modified:
2 years, 2 months ago
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6279 - Make HashContainer movable and optimize resizing by moving entries.

Patch Set 1 #

Patch Set 2 : Forgot IntMap. Remove changes not needed. Minor fix. #

Total comments: 6

Patch Set 3 : Remove unneeded ctor. Rename _assign() #

Patch Set 4 : remove more unused ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M compiled/IntMap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/Map.h View 1 2 2 chunks +22 lines, -6 lines 0 comments Download
M compiled/StringMap.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
hub
2 years, 2 months ago (2018-01-23 21:20:26 UTC) #1
sergei
https://codereview.adblockplus.org/29677755/diff/29677823/compiled/Map.h File compiled/Map.h (right): https://codereview.adblockplus.org/29677755/diff/29677823/compiled/Map.h#newcode165 compiled/Map.h:165: entry_type* _assign(entry_type* existing, const entry_type& entry) We normally don't ...
2 years, 2 months ago (2018-01-24 18:37:12 UTC) #2
hub
updated https://codereview.adblockplus.org/29677755/diff/29677823/compiled/Map.h File compiled/Map.h (right): https://codereview.adblockplus.org/29677755/diff/29677823/compiled/Map.h#newcode165 compiled/Map.h:165: entry_type* _assign(entry_type* existing, const entry_type& entry) On 2018/01/24 ...
2 years, 2 months ago (2018-01-24 19:32:01 UTC) #3
sergei
https://codereview.adblockplus.org/29677755/diff/29677823/compiled/StringMap.h File compiled/StringMap.h (right): https://codereview.adblockplus.org/29677755/diff/29677823/compiled/StringMap.h#newcode57 compiled/StringMap.h:57: StringSetEntry& operator=(StringSetEntry&&) = default; On 2018/01/24 19:32:01, hub wrote: ...
2 years, 2 months ago (2018-01-25 10:55:07 UTC) #4
sergei
I think the commit message should be also changed, it's essentially making HashContainer based classes ...
2 years, 2 months ago (2018-01-25 11:06:26 UTC) #5
hub
updated. changed commit message (and review title) https://codereview.adblockplus.org/29677755/diff/29677823/compiled/StringMap.h File compiled/StringMap.h (right): https://codereview.adblockplus.org/29677755/diff/29677823/compiled/StringMap.h#newcode57 compiled/StringMap.h:57: StringSetEntry& operator=(StringSetEntry&&) ...
2 years, 2 months ago (2018-01-25 15:11:11 UTC) #6
sergei
2 years, 2 months ago (2018-01-25 15:20:57 UTC) #7
On 2018/01/25 15:11:11, hub wrote:
...
> (I was convinced they were needed, must have been a side effect, done now)

Maybe they are still needed but theoretically should not be :) let's see whether
and how the rest code is compiled.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5